Bug 265967
| Summary: | Fix failing '%' valid and invalid 'shape-image-threshold' parsing tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=191939 | ||
Ahmad Saleem
Hi Team,
While going through bug 191939, I noticed that we fail 'shape-image-threshold' test for % values and while looking into Safari failures on WPT, I came across us failing following:
WPT Test Cases: https://wpt.fyi/results/css/css-shapes/parsing?label=master&label=experimental&aligned=&q=shape-image-threshold+safari%3Afail
I just wanted to raise this as separate so we can track it better.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/119632565>
Ahmad Saleem
Changing `CSSProperties.json` from:
"style-converter": "Number<float>",
"parser-grammar": "<number>"
to
"style-converter": "Opacity",
"parser-grammar": "<alpha-value>"
___
It fixes - shape-image-threshold-computed.html but it also lead to failure in `css/css-typed-om/the-stylepropertymap/properties/shape-image-threshold.html`.
We still need to fix `invalid` test post above fix.