Bug 26594 – JSC needs to support Date.toISOString

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Oliver Hunt]

Date.toJSON depends on Date.toISOString

[Oliver Hunt]

Created attachment 31627 [details]
Support Date.toISOString

[Oliver Hunt]

Created attachment 31628 [details]
Updated patch

[Sam Weinig]

Comment on attachment 31628 [details]
Updated patch

> +    
> +    const bool utc = true;
> +    
> +    DateInstance* thisDateObj = asDateInstance(thisValue); 
> +    double milli = thisDateObj->internalNumber();
> +    if (isnan(milli))
> +        return jsNontrivialString(exec, "Invalid Date");

According to http://wiki.ecmascript.org/lib/exe/fetch.php?id=es3.1%3Aes3.1_proposal_working_draft&cache=cache&media=es3.1:es5_candidate_errata_june_17.pdf, we should throwing a RangeError for non-finite values.

> +    
> +    GregorianDateTime t;
> +    thisDateObj->msToGregorianDateTime(milli, true, t);

I believe the intent of the utc constant is to use it here instead of passing true.


r- for the isnan bit.

[Sam Weinig]

Comment on attachment 31628 [details]
Updated patch

Oliver and I discussed this a bit on IRC.

[Sam Weinig]

Comment on attachment 31628 [details]
Updated patch

Oliver and I discussed this a bit on IRC.

[Oliver Hunt]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/runtime/DatePrototype.cpp
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/js/date-toisostring-expected.txt
	A	LayoutTests/fast/js/date-toisostring.html
	A	LayoutTests/fast/js/resources/date-toisostring.js
Committed r44929