Bug 265923
| Summary: | Add Keyboard Lock option into Fullscreen API | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Byungseon(Sun) Shin <sun.shin> |
| Component: | DOM | Assignee: | Byungseon(Sun) Shin <sun.shin> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, possum.bracing0v, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 264843 | ||
Byungseon(Sun) Shin
Add stubs for Fullscreen Keyboard Lock API by the following issue.
- https://github.com/whatwg/fullscreen/issues/231
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Byungseon(Sun) Shin
Pull request: https://github.com/WebKit/WebKit/pull/21374
Radar WebKit Bug Importer
<rdar://problem/119590187>
EWS
Committed 272933@main (d7997e2d3966): <https://commits.webkit.org/272933@main>
Reviewed commits have been landed. Closing PR #21374 and removing active labels.
Jeffrey Blanz
Considering this demo does not work on safari technology preview 194, which is on 277790@main, then is this not resolved?
Chrome standard: https://developer.chrome.com/blog/better-full-screen-mode
Chrome demo: https://fullscreen-keyboard-lock.glitch.me/
Byungseon(Sun) Shin
@Jeffrey, thanks for your comments on this issue.
This bug is for adding the feature flag on the webkit side.
And the actual implementation is being handled by the bug https://bugs.webkit.org/show_bug.cgi?id=264843.
And I am waiting for the WebKit team's feedback.
Hopefully the implementation part will be merged soon as well.