Bug 26585

Summary:

Exposing page rects

Product:

WebKit

Reporter:

Jakob Truelsen <antialize>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

manyoso

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Patch exposing pagerects	eric: review-
Now in style	manyoso: review-

Jakob Truelsen

Reported 2009-06-21 07:20:07 PDT

Please expose the page rects of the PrintContext, so that I may figure out on what page and where an element is printed.

Attachments
Patch exposing pagerects (1.31 KB, patch) 2009-06-21 07:21 PDT, Jakob Truelsen	eric: review-	Details Formatted Diff Diff
Now in style (1.32 KB, patch) 2009-06-22 01:25 PDT, Jakob Truelsen	manyoso: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jakob Truelsen

Comment 1 2009-06-21 07:21:32 PDT

Created attachment 31616 [details] Patch exposing pagerects

Eric Seidel (no email)

Comment 2 2009-06-21 13:28:42 PDT

Comment on attachment 31616 [details] Patch exposing pagerects What code uses this? Also there are 2 style violations here. the { on the same line and the spacing around the &. Please read the style guide: http://webkit.org/coding/coding-style.html

Jakob Truelsen

Comment 3 2009-06-22 01:25:46 PDT

Created attachment 31637 [details] Now in style I have tried to make the patch align with the styling guidelines.. I use this method in some changes that I am making to to qt back end, they are still far to much of a hack to get merged.. However as this seems like a simple and usefull getter method, I was hoping to get it accepted sooner rather then later, so there are less stuff for me to manage.

Adam Treat

Comment 4 2009-06-23 17:53:18 PDT

Comment on attachment 31637 [details] Now in style Why do you want to add a get method that is never used? WebCore is not meant to serve as API for a client.

Adam Treat

Comment 5 2009-06-23 17:53:35 PDT

Comment on attachment 31637 [details] Now in style Why do you want to add a get method that is never used? WebCore is not meant to serve as API for a client.

Adam Treat

Comment 6 2009-07-30 07:07:06 PDT

Been a month. Closing as invalid until can figure out what it is for.

Note You need to log in before you can comment on or make changes to this bug.