Bug 265791
| Summary: | Switch to libwebrtc new DNS resolver interface | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> |
| Component: | WebRTC | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
youenn fablet
Switch to libwebrtc new DNS resolver interface
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/119133276>
youenn fablet
Pull request: https://github.com/apple/WebKit/pull/961
youenn fablet
Pull request: https://github.com/apple/WebKit/pull/963
youenn fablet
Pull request: https://github.com/WebKit/WebKit/pull/21638
EWS
Committed 272029@main (fb5c6b1cd67e): <https://commits.webkit.org/272029@main>
Reviewed commits have been landed. Closing PR #21638 and removing active labels.
Diego Pino
Build error in WPE + LibWebRTC after this change.
```
/usr/bin/ld: UnifiedSource-54928a2b-18.cpp:(.text+0x2cfc): undefined reference to `vtable for WebKit::LibWebRTCDnsResolverFactory'
/usr/bin/ld: Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-18.cpp.o:(.data.rel.ro+0x520): undefined reference to `WebKit::LibWebRTCDnsResolverFactory::Resolver::Start(rtc::SocketAddress const&, absl::AnyInvocable<void ()>)'
/usr/bin/ld: Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-18.cpp.o:(.data.rel.ro+0x528): undefined reference to `WebKit::LibWebRTCDnsResolverFactory::Resolver::Start(rtc::SocketAddress const&, int, absl::AnyInvocable<void ()>)'
```
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/22158
EWS
Committed 272418@main (031a06346222): <https://commits.webkit.org/272418@main>
Reviewed commits have been landed. Closing PR #22158 and removing active labels.