Bug 265713

Summary: AX: Roll back a retracted ARIA change: default aria-level for heading role should not randomly be 2.
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: Joshua Hoffman <jhoffman23>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, hi, jhoffman23, pangle, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description James Craig 2023-12-01 18:20:13 PST 
Rollback a retracted ARIA change: default aria-level should not randomly be 2.

Rollback or update to remove this diff:
https://github.com/WebKit/WebKit/commit/09bbaddcb99391c80fe4adde695393cc6de97c80

It shipped in ARIA 1.1 (I missed it or I would have objected then)
https://www.w3.org/TR/wai-aria-1.1/#heading

But was removed (for good reason) in ARIA 1.2
https://www.w3.org/TR/wai-aria-1.2/#heading

So we should role back the change in WebKit.


# Some justification: 
The spec change (default is 2 wtf?) prioritizes spec authors over users, authors, the inverse priority of the web platform design principles... 

1. Screen reader users hear additional verbose information that may not be accurate: "heading level 2" instead of just "heading" 
2. There's no way for an author to provide a heading with an unspecified level.

So it's good that the ARIA spec removed it, and we should get this out of WebKit, too.
Comment 1 Radar WebKit Bug Importer 2023-12-01 18:20:21 PST 
<rdar://problem/119059172>
Comment 2 James Craig 2023-12-01 18:22:13 PST 
> we should role back the change

I've got roles rolling around in my brains. Roll it back!
Comment 3 Joshua Hoffman 2023-12-02 21:22:37 PST 
Created attachment 468840 [details]
Patch
Comment 4 Joshua Hoffman 2023-12-03 18:24:28 PST 
Created attachment 468848 [details]
Patch
Comment 5 Joshua Hoffman 2023-12-03 19:34:41 PST 
Created attachment 468850 [details]
Patch
Comment 6 Joshua Hoffman 2023-12-03 21:41:06 PST 
Created attachment 468857 [details]
Patch
Comment 7 EWS 2023-12-04 11:43:48 PST 
Committed 271497@main (a61b53287171): <https://commits.webkit.org/271497@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468857 [details].