Bug 265676
| Summary: | Fix Lexer build with -Werror=type-limits | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Olivier Blin <olivier.blin> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | darin, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=265478 | ||
Olivier Blin
After 271373@main which uses char32_t instead of UChar32, build of Lexer.cpp is broken with -Werror=type-limits:
Source/JavaScriptCore/parser/Lexer.cpp:905:22: error: comparison of unsigned expression in ‘>= 0’ is always true [-Werror=type-limits]
This assert should be removed:
ASSERT(codePoint >= 0)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Olivier Blin
Pull request: https://github.com/WebKit/WebKit/pull/21169
EWS
Committed 271393@main (52f1f953c77c): <https://commits.webkit.org/271393@main>
Reviewed commits have been landed. Closing PR #21169 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/119040842>