Bug 265472

Summary:

AX: associatedPluginParent is accessing the main thread every time a notification is fired

Product:

WebKit

Reporter:

Dominic Mazzoni <dm_mazzoni>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Dominic Mazzoni

Reported 2023-11-28 14:11:38 PST

Tiny optimization: every time AXPostNotificationWithUserInfo is called, it checks associatedPluginParent, which currently goes to the main thread. Since it's almost always nil unless we happen to be on a PDF element, associatedPluginParent should check the isolated object without going to the main thread.

Attachments
Patch (1.52 KB, patch) 2023-11-28 14:17 PST, Dominic Mazzoni	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-11-28 14:11:53 PST

<rdar://problem/118898537>

Dominic Mazzoni

Comment 2 2023-11-28 14:17:11 PST

Created attachment 468792 [details] Patch

EWS

Comment 3 2023-11-28 19:27:55 PST

Committed 271258@main (7db75daadf99): <https://commits.webkit.org/271258@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468792 [details].

Note You need to log in before you can comment on or make changes to this bug.