Bug 265398
| Summary: | Generate serialization of webrtc::WebKitEncodedFrameInfo | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> |
| Component: | WebKit Misc. | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alex Christensen
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/118845948>
Alex Christensen
Pull request: https://github.com/WebKit/WebKit/pull/20949
EWS
Committed 271173@main (c68f7caf5b37): <https://commits.webkit.org/271173@main>
Reviewed commits have been landed. Closing PR #20949 and removing active labels.
Diego Pino
Bot 'WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004' is failing now with the following error:
WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004
```
FAILED:
In file included from ../../../Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h:28,
from ../../../Source/WebKit/Shared/RTCWebKitEncodedFrameInfo.h:32,
from DerivedSources/WebKit/GeneratedSerializers.cpp:131:
../../../Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h:31:10: fatal error: CoreFoundation/CFBase.h: No such file or directory
31 | #include <CoreFoundation/CFBase.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
[1659/2276] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/SerializedTypeInfo.cpp.o
```
This the only WPE bot that uses LibWebRTC.
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/21010
Alex Christensen
Thanks, Diego! Does all Linux EWS not use libwebrtc?
Diego Pino
(In reply to Alex Christensen from comment #6)
> Thanks, Diego! Does all Linux EWS not use libwebrtc?
All WebKitGTK and WPE bots use GStreamer WebRTC. There's only one bot that builds with LibWebRTC (`--cmakeargs=-DUSE_GSTREAMER_WEBRTC=OFF`), which is the WPE-Linux-64-bit-Release-Ubuntu-LTS-Build bot.
The fix I attempted fixed WPE-Linux-64-bit-Release-Ubuntu-LTS-Build but the patch broken compilation in all other Linux EWS bots as well as WinCairo, so the fix is not correct.
Diego Pino
Sorry, the only bot that builds with LibWebRTC is WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004.
https://build.webkit.org/#/builders/2/builds/8573
EWS
Committed 272602@main (995816c95079): <https://commits.webkit.org/272602@main>
Reviewed commits have been landed. Closing PR #21010 and removing active labels.