Bug 265322
| Summary: | [JSC] Wasm GC struct members should be naturally aligned | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Griego <joseph.j.griego> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | vidavera, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Joseph Griego
At present, e.g. ref members can be placed anywhere within the JSWebAssemblyStruct::m_payload allocation; for concurrent JIT on 32-bit (and, AIUI, concurrent GC on 64-bit,) these need to be 8-byte aligned.
Also, I suspect aligning the scalar types could be a slight performance win on ARM.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Joseph Griego
Pull request: https://github.com/WebKit/WebKit/pull/20878
EWS
Committed 271146@main (c95abf8658be): <https://commits.webkit.org/271146@main>
Reviewed commits have been landed. Closing PR #20878 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/118835663>