Bug 265261
Summary: | Unsupport encodings (e.g., 'x-mac-turkish', 'x-mac-greek' etc.) WPT failures | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
Component: | Text | Assignee: | Ahmad Saleem <ahmad.saleem792> |
Status: | REOPENED | ||
Severity: | Normal | CC: | annevk, ap, commit-queue, karlcow, mmaxfield, webkit-bug-importer |
Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
URL: | http://wpt.live/encoding/unsupported-labels.window.html | ||
Bug Depends on: | 267969, 270658 | ||
Bug Blocks: | 179303 |
Ahmad Saleem
Hi Team,
While going through WPT failures, I came across following failing test in Safari / WebKit.
WPT Test Case: https://wpt.fyi/results/encoding/unsupported-labels.window.html?label=master&label=experimental&aligned&q=safari%3Afail
Just wanted to raise so we can track it.
Adding 'BrowserCompat' since only Safari / WebKit is failing them.
___
Following are not supported by Encoding Standard:
> euc-tw
> windows-936-2000
> x-mac-ce
> x-mac-centraleurroman
> x-mac-greek
> x-mac-turkish
^ few are mentioned here with comment that they are not in standard: https://searchfox.org/wubkat/source/Source/WebCore/PAL/pal/text/TextCodecICU.cpp#97
____
Thanks!
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/118944539>
Ahmad Saleem
> Source/WebCore/PAL/pal/text/TextCodecCJK.cpp
In -- TextCodecCJK::registerEncodingNames --
Remove > "windows-936-2000"_s
> Source/WebCore/PAL/pal/text/TextCodecICU.cpp
In -- DECLARE_ALIASE --
Remove from '/ Encodings below are not in the standard.' onward:
DECLARE_ALIASES(x_mac_greek, "windows-10006"_s, "macgr"_s, "x-MacGreek"_s);
DECLARE_ALIASES(x_mac_centraleurroman, "windows-10029"_s, "x-mac-ce"_s, "macce"_s, "maccentraleurope"_s, "x-MacCentralEurope"_s);
DECLARE_ALIASES(x_mac_turkish, "windows-10081"_s, "mactr"_s, "x-MacTurkish"_s);
and
In -- EncodingName --
Remove:
// Encodings below are not in the standard.
DECLARE_ENCODING_NAME("x-mac-greek"_s, x_mac_greek),
DECLARE_ENCODING_NAME("x-mac-centraleurroman"_s, x_mac_centraleurroman),
DECLARE_ENCODING_NAME("x-mac-turkish"_s, x_mac_turkish),
DECLARE_ENCODING_NAME_NO_ALIASES("EUC-TW"_s),
___
It progresses all failing WPT tests.
Ahmad Saleem
@Karl - is there any internal requirement by Apple to retain or I can try to do PR and match other browsers?
Ahmad Saleem
Just running through EWS to see how many more tests to modify and if there are anything else platform specific - https://github.com/WebKit/WebKit/pull/22273 (In Draft).
Ahmad Saleem
Just to update - looks now ready to go (even if we don't land right now - it will be good for future reference) - https://github.com/WebKit/WebKit/pull/22273
EWS
Committed 275797@main (a78cd83130cb): <https://commits.webkit.org/275797@main>
Reviewed commits have been landed. Closing PR #22273 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 270658
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/40354