Bug 265143

Summary:

[IFC] Move "content has position dependent width" traversal to RenderText

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
[fast-cq]Patch	none

zalan

Reported 2023-11-20 08:18:51 PST

ssia

Attachments
Patch (20.00 KB, patch) 2023-11-20 08:24 PST, zalan	no flags	Details Formatted Diff Diff
Patch (20.00 KB, patch) 2023-11-20 11:36 PST, zalan	no flags	Details Formatted Diff Diff
Patch (20.00 KB, patch) 2023-11-20 15:25 PST, zalan	no flags	Details Formatted Diff Diff
[fast-cq]Patch (20.25 KB, patch) 2023-11-20 17:16 PST, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2023-11-20 08:24:40 PST

Created attachment 468682 [details] Patch

Antti Koivisto

Comment 2 2023-11-20 08:29:45 PST

Comment on attachment 468682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=468682&action=review > Source/WebCore/layout/layouttree/LayoutInlineTextBox.h:58 > +inline void InlineTextBox::updateContent(String newContent, bool canUseSimpleFontCodePath, bool canUseSimplifiedContentMeasuring, bool hasPositionDependentContentWidth) maybe we'll need an OptionSet soon

zalan

Comment 3 2023-11-20 08:30:13 PST

(In reply to Antti Koivisto from comment #2) > Comment on attachment 468682 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=468682&action=review > > > Source/WebCore/layout/layouttree/LayoutInlineTextBox.h:58 > > +inline void InlineTextBox::updateContent(String newContent, bool canUseSimpleFontCodePath, bool canUseSimplifiedContentMeasuring, bool hasPositionDependentContentWidth) > > maybe we'll need an OptionSet soon very true!

zalan

Comment 4 2023-11-20 11:36:31 PST

Created attachment 468688 [details] Patch

zalan

Comment 5 2023-11-20 15:25:38 PST

Created attachment 468692 [details] Patch

zalan

Comment 6 2023-11-20 17:16:09 PST

Created attachment 468694 [details] [fast-cq]Patch

EWS

Comment 7 2023-11-20 17:50:15 PST

Committed 270993@main (d36b968cd91a): <https://commits.webkit.org/270993@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468694 [details].

Radar WebKit Bug Importer

Comment 8 2023-11-20 17:51:24 PST

<rdar://problem/118666798>

Note You need to log in before you can comment on or make changes to this bug.