Bug 265098
| Summary: | Elements should avoid floats even if they are as high as LayoutUnit::max() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another failing test but I don't know whether it is applicable as much since it seems to be edge case:
Blink Commit: https://chromium.googlesource.com/chromium/blink/+/af76e7423374640fa2aa5e5c550709e9a7fd39c4
Test Case: https://jsfiddle.net/01r2ez5f/show
^ Chrome Canary 121 - Passes & Firefox show below error:
Elements should avoid floats even if they are as high as LayoutUnit::max()
a
FAIL:
Expected 33554431 for offsetTop, but got 27.
<table data-offset-y="33554431" id="table">
<tbody><tr><td>a</td>
</tr></tbody></table>
While WebKit ToT running via 'run-webkit-tests' have following output:
Elements should avoid floats even if they are as high as LayoutUnit::max()
a
FAIL:
Expected 33554432 for offsetTop, but got 33554431.
<table data-offset-y="33554432" id="table">
<tbody><tr><td>a</td>
</tr></tbody></table>
__
Since it is failing with 1 px, I just wanted to raise to get input whether it is worth fixing or we can just ignore.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/118795348>
Ahmad Saleem
This 1px might have been fixed here: https://github.com/WebKit/WebKit/commit/2afefe7449cd82d4b70c9ed85add5827f44e7278
Not confirmed, just speculating.
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/55453
EWS
Committed 304586@main (5b60e9ccada1): <https://commits.webkit.org/304586@main>
Reviewed commits have been landed. Closing PR #55453 and removing active labels.