Bug 26492

Summary:

Some tests in LayoutTests/editing/deleting could be text-only rather than dumping render trees

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
converts 4845371.html 4875189.html 5026848-1.html	none
converts 5126166.html 5156801-2.html 5300379.html	none
converts 5390681-2.html list-item-1.html merge-endOfParagraph.html	none
converts merge-no-br.html merge-unrendered-space.html merge-whitespace-pre.html	none
converts paragraph-in-preserveNewline.html table-cells.html whitespace-pre-1.html	none
converts 5390681-2.html list-item-1.html merge-endOfParagraph.html	none
converts merge-no-br.html merge-unrendered-space.html merge-whitespace-pre.html	none
converts smart-delete-001.html smart-delete-002.html smart-delete-003.html smart-delete-004.html	none

Ryosuke Niwa

Reported 2009-06-17 13:55:24 PDT

There are tests in LayoutTests/editing/deleting that must be using dumpAsText tests instead of layout tests.

Attachments
converts 4845371.html 4875189.html 5026848-1.html (18.95 KB, patch) 2009-06-17 14:19 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
converts 5126166.html 5156801-2.html 5300379.html (15.89 KB, patch) 2009-06-17 15:28 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
converts 5390681-2.html list-item-1.html merge-endOfParagraph.html (19.36 KB, patch) 2009-06-17 15:29 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
converts merge-no-br.html merge-unrendered-space.html merge-whitespace-pre.html (14.76 KB, patch) 2009-06-17 15:30 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
converts paragraph-in-preserveNewline.html table-cells.html whitespace-pre-1.html (27.00 KB, patch) 2009-06-17 15:31 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
converts 5390681-2.html list-item-1.html merge-endOfParagraph.html (26.70 KB, patch) 2009-06-17 15:32 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
converts merge-no-br.html merge-unrendered-space.html merge-whitespace-pre.html (23.46 KB, patch) 2009-06-17 15:33 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
converts smart-delete-001.html smart-delete-002.html smart-delete-003.html smart-delete-004.html (39.52 KB, patch) 2009-06-17 15:36 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2009-06-17 14:19:35 PDT

Created attachment 31431 [details] converts 4845371.html 4875189.html 5026848-1.html

Ryosuke Niwa

Comment 2 2009-06-17 15:28:43 PDT

Created attachment 31443 [details] converts 5126166.html 5156801-2.html 5300379.html

Ryosuke Niwa

Comment 3 2009-06-17 15:29:10 PDT

Created attachment 31444 [details] converts 5390681-2.html list-item-1.html merge-endOfParagraph.html

Ryosuke Niwa

Comment 4 2009-06-17 15:30:59 PDT

Created attachment 31445 [details] converts merge-no-br.html merge-unrendered-space.html merge-whitespace-pre.html

Ryosuke Niwa

Comment 5 2009-06-17 15:31:48 PDT

Created attachment 31446 [details] converts paragraph-in-preserveNewline.html table-cells.html whitespace-pre-1.html

Ryosuke Niwa

Comment 6 2009-06-17 15:32:55 PDT

Created attachment 31447 [details] converts 5390681-2.html list-item-1.html merge-endOfParagraph.html

Ryosuke Niwa

Comment 7 2009-06-17 15:33:53 PDT

Created attachment 31448 [details] converts merge-no-br.html merge-unrendered-space.html merge-whitespace-pre.html

Ryosuke Niwa

Comment 8 2009-06-17 15:36:11 PDT

Created attachment 31452 [details] converts smart-delete-001.html smart-delete-002.html smart-delete-003.html smart-delete-004.html

Mark Rowe (bdash)

Comment 9 2009-06-17 17:41:25 PDT

We typically don't attach multiple distinct patches to a single bug report. Is there any reason that these changes aren't in a single patch?

Ryosuke Niwa

Comment 10 2009-06-17 17:44:30 PDT

(In reply to comment #9) > We typically don't attach multiple distinct patches to a single bug report. Is > there any reason that these changes aren't in a single patch? > Eric requested that I make each patch small enough to review. The initial patch will be more than 100KB, so I decided to split it up into a group of 3-4 tests. If you'd prefer, I'm more than happy to attach another patch that contains all the tests.

Alexey Proskuryakov

Comment 11 2010-06-12 15:17:13 PDT

These patches aren't marked for review. Should they be? Are they obsolete?

Ryosuke Niwa

Comment 12 2010-07-27 00:19:27 PDT

(In reply to comment #11) > These patches aren't marked for review. Should they be? Are they obsolete? There was an IRC discussion in which we decided that we should wait to convert these tests until dump-as-markup is implemented. So those patches are all obsolete now.

Note You need to log in before you can comment on or make changes to this bug.