Bug 264905
| Summary: | Sync 'RTCRtpScriptTransform.idl' with WebIDL Specification | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | WebRTC | Assignee: | youenn fablet <youennf> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While looking into browser specific failures in WebRTC, I noticed that we fail few 'idlharness' tests for 'RTCRtpScriptTransform' and while looking into web specification, I noticed two things, which in my local testing progress failing tests:
Web-Spec: https://www.w3.org/TR/webrtc-encoded-transform/#RTCRtpScriptTransformer-interfaces
WebKit Source: Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.idl
Current:
] interface RTCRtpScriptTransform : EventTarget {
To:
] interface RTCRtpScriptTransform {
and
Current:
[CallWith=CurrentGlobalObject] constructor(Worker worker, any options, optional sequence<object> transfer);
To:
[CallWith=CurrentGlobalObject] constructor(Worker worker, optional any options, optional sequence<object> transfer);
____
Just wanted to raise, so we can fix it. Only Firefox Nightly 121 passes them yet, so not adding 'BrowserCompat' tag.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Test Case: https://wpt.fyi/results/webrtc-encoded-transform/idlharness.https.window.html?label=master&label=experimental&aligned=
Test Case Live Link: https://wpt.live/webrtc-encoded-transform/idlharness.https.window.html
Radar WebKit Bug Importer
<rdar://problem/118728503>
youenn fablet
Pull request: https://github.com/WebKit/WebKit/pull/21145
EWS
Committed 271380@main (91ff5d82ae24): <https://commits.webkit.org/271380@main>
Reviewed commits have been landed. Closing PR #21145 and removing active labels.