Bug 264889
| Summary: | [LBSE] Root 'opacity' should be extended to 'RenderSVGRoot' | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While trying to look into some opacity related test case from bug 116856 link below, I noticed that the zooming out cause issue in Minibrowser when LBSE is turned on on test case.
Test Case: https://bug-116856-attachments.webkit.org/attachment.cgi?id=203029
^ Zooming out using LBSE cause the blocks to have 'black' overlap areas.
WebKit Source: https://searchfox.org/wubkat/rev/7753b1fdea4b4605b4851dec61966b8b7247302a/Source/WebCore/rendering/svg/SVGRenderingContext.cpp#99
Current:
float opacity = (renderer.isLegacyRenderSVGRoot() || isRenderingMask) ? 1 : style.opacity();
to
float opacity = (renderer.isRenderOrLegacyRenderSVGRoot() || isRenderingMask) ? 1 : style.opacity();
^ this fixes the issue for me on local build.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
PR: https://github.com/WebKit/WebKit/pull/20552
Ahmad Saleem
JSFiddle: https://jsfiddle.net/sad7z94e/2/
Potential Expected file: https://jsfiddle.net/vf4zctbr/
Although I have no idea whether I have to make it 'LBSE' specific or just keep it for all.
Radar WebKit Bug Importer
<rdar://problem/118724556>
Ahmad Saleem
Seems to be now fixed with WebKit ToT using test case from Comment 0 and zooming-out.