Bug 26479

Summary: Share code between filterEffects
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: jeffschiller
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 68469, 26389, 26480    
Description Flags
Share the code oliver: review+

Description Dirk Schulze 2009-06-17 07:15:49 PDT
We can share more code between the effects. The imageBuffer creation and drawRect calculation to Filtereffect.
Comment 1 Dirk Schulze 2009-06-17 07:18:17 PDT
Created attachment 31412 [details]
Share the code

share the code
Comment 2 Dirk Schulze 2009-06-17 08:00:06 PDT
*** Bug 26478 has been marked as a duplicate of this bug. ***
Comment 3 Oliver Hunt 2009-06-18 01:11:14 PDT
Comment on attachment 31412 [details]
Share the code

I think it makes sense to hoist 
 78     GraphicsContext* filterContext = getEffectContext();
 79     if (!filterContext)
 80         return;
to above the creation of dstRect for clarity
Comment 4 Dirk Schulze 2009-06-18 13:01:23 PDT
landed in r44810.