Bug 264658
| Summary: | [GTK] Switch to use GTK4 by default | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | WebKitGTK | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, dpino |
| Priority: | P2 | Keywords: | Gtk |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Garcia Campos
Change USE_GTK4 default value to ON.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/20361
EWS
Committed 270765@main (80028d273216): <https://commits.webkit.org/270765@main>
Reviewed commits have been landed. Closing PR #20361 and removing active labels.
Diego Pino
After this change Ubuntu LTS bot was failing with the following error:
https://build.webkit.org/#/builders/68/builds/29215
```
CMake Error at Source/cmake/WebKitFeatures.cmake:323 (message):
USE_GTK4 conflicts with USE_SOUP2. You must disable one or the other.
Call Stack (most recent call first):
Source/cmake/WebKitFeatures.cmake:331 (_WEBKIT_OPTION_ENFORCE_CONFLICTS)
Source/cmake/WebKitFeatures.cmake:356 (_WEBKIT_OPTION_ENFORCE_ALL_CONFLICTS)
Source/cmake/OptionsGTK.cmake:164 (WEBKIT_OPTION_END)
Source/cmake/WebKitCommon.cmake:232 (include)
CMakeLists.txt:21 (include)
```
The bot built with USE_SOUP2=ON. After removing this setting the build was failing because libgtk4-dev was not installed. This bot builds using only system libraries, so libgtk4-dev has to be added to the list of WebKitGTK dependency packages.
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/20546
EWS
Committed 270775@main (cc67c85e30f9): <https://commits.webkit.org/270775@main>
Reviewed commits have been landed. Closing PR #20546 and removing active labels.