Summary: | Out of bounds read / occasional crash (no security consequence) in comment parsing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Evans <scarybeasts> | ||||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
URL: | https://cevans-app.appspot.com/static/webkitcharsetoobread.html | ||||||||
Attachments: |
|
Description
Chris Evans
2009-06-16 16:01:36 PDT
Created attachment 31390 [details]
Fixes out-of-bounds reads.
Comment on attachment 31390 [details]
Fixes out-of-bounds reads.
Thanks for the patch, but we'll need to include a ChangeLog before landing this.
Also, WebKit coding style has no braces around a single line if body. Created attachment 31528 [details]
Fix out-of-bounds reads.
Request land of patch. Changes since last version: - Adhere to coding style (thanks Darin)! - Add ChangeLog entry. - Includes justification of why I can't reasonably add a test. Comment on attachment 31528 [details]
Fix out-of-bounds reads.
Tabs in the ChangeLog. Otherwise this looks great. Will have to be landed manually, my script won't be able to fix the tabs (it's not that smart).
Assigned for landing. Corrected tabs and landed in http://trac.webkit.org/changeset/44865. PLEASE add bug numbers to ChangeLog entries in the future. You got it. Sorry :) |