Bug 264446

Summary: Remove special handling of ::before and ::after on RUBY elements
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, ntim, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Local Build 'RenderTreeBuilderRuby' file (as TXT) none

Ahmad Saleem
Reported 2023-11-08 15:19:04 PST
Created attachment 468524 [details] Local Build 'RenderTreeBuilderRuby' file (as TXT) Hi Team, While going through Blink's commit, I came across following clean-up patch but I don't know whether we can do this or not but just wanted to raise this bug to get input. @Alan - it would be good to get your insight due to on-going 'Ruby' related Layout work, you are leading. Blink Commit: https://chromium.googlesource.com/chromium/blink/+/81eb8745dfd7d21fc9588220eed989d901cb7276 WebKit Source: Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp ___ I have local patch to remove and do all clean-up, attaching here. NOTE: I didn't run any local tests or WPT tests but just wanted to get input before doing so. Thanks!
Attachments
Local Build 'RenderTreeBuilderRuby' file (as TXT) (14.76 KB, text/plain)
2023-11-08 15:19 PST, Ahmad Saleem 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-11-15 15:20:14 PST
<rdar://problem/118478034>
Ahmad Saleem
Comment 2 2023-11-15 15:47:16 PST
PR Attempt - let's give EWS something to test: https://github.com/WebKit/WebKit/pull/20565
EWS
Comment 3 2023-11-16 06:07:54 PST
Committed 270823@main (3c701132f001): <https://commits.webkit.org/270823@main> Reviewed commits have been landed. Closing PR #20565 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.