Bug 26437

Summary: commit-log-editor should match ambient line endings
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch darin: review+

Adam Barth
Reported 2009-06-16 01:27:27 PDT
Let's see where this trail of tears leads. Currently, the commit-log-editor dumps the ChangeLog into the commit message without regard to line endings (which might not match in these two cases). It should be smarter and match the line endings that are already in the commit message. Patch forthcoming.
Attachments
patch (2.09 KB, patch)
2009-06-16 01:27 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
patch (2.10 KB, patch)
2009-06-16 01:30 PDT, Adam Barth 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-06-16 01:27:55 PDT
Created attachment 31341 [details] patch
Adam Barth
Comment 2 2009-06-16 01:30:13 PDT
Created attachment 31342 [details] patch slight improvement
David Levin
Comment 3 2009-06-16 10:17:48 PDT
Assigned to Adam for landing.
Adam Barth
Comment 4 2009-06-16 11:19:54 PDT
Sending WebKitTools/ChangeLog Sending WebKitTools/Scripts/commit-log-editor Transmitting file data .. Committed revision 44727.
Note You need to log in before you can comment on or make changes to this bug.