Bug 26433

Summary:

[V8] Exception from JavaScript propagates to main script

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

WebCore JavaScript

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, dglazkov, japhet

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://webblaze.org/abarth/tests/jswrite/test3.html

Attachments:

Description	Flags
Patch to isolate compile time exceptions in javascript URLs	abarth: review+, abarth: commit-queue-

Adam Barth

Reported 2009-06-15 22:29:27 PDT

If a script sets an iframe's src attribute to a JavaScript URL that throws an exception, then that exception is improperly propagated from the JavaScript URL to the main script. Test case: http://webblaze.org/abarth/tests/jswrite/test3.html

Attachments
Patch to isolate compile time exceptions in javascript URLs (6.33 KB, patch) 2009-08-25 01:43 PDT, Mads Ager	abarth: review+ abarth: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2009-06-17 01:43:17 PDT

I cannot reproduce this with Safari 3.2.3 or with a local debug build of r44713.

Adam Barth

Comment 2 2009-06-17 08:56:59 PDT

This bug appears to be specific to the V8 bindings.

Dimitri Glazkov (Google)

Comment 3 2009-06-19 14:18:26 PDT

I'll look. Thanks for the report.

Dimitri Glazkov (Google)

Comment 4 2009-06-25 11:27:52 PDT

Nate, can you check on this?

Adam Barth

Comment 5 2009-08-19 19:32:57 PDT

Any progress on this Nate? Should be an easy fix.

Adam Barth

Comment 6 2009-08-20 22:43:03 PDT

In the lost time, Nate made some progress getting to the root cause of this bug. He's going to touch base with the V8 folks and confirm his understanding.

Mads Ager

Comment 7 2009-08-25 01:43:36 PDT

Created attachment 38536 [details] Patch to isolate compile time exceptions in javascript URLs The problem is that we only isolate runtime exceptions and not compile time exceptions in javascript URLs.

Adam Barth

Comment 8 2009-08-25 09:17:06 PDT

Comment on attachment 38536 [details] Patch to isolate compile time exceptions in javascript URLs This looks great. The only problem is you indented using two spaces instead of four. :) Someone can either fix this when landing manually, or you can post an updated patch that we can land automatically.

Adam Barth

Comment 9 2009-08-25 12:28:27 PDT

I'll land this manually.

Adam Barth

Comment 10 2009-08-25 12:31:58 PDT

Committed r47753: <http://trac.webkit.org/changeset/47753>

Note You need to log in before you can comment on or make changes to this bug.