Bug 264303
| Summary: | [css-flex] Flex layout incorrectly dirties preferred width bits towards the end of layout | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
| Component: | Layout and Rendering | Assignee: | Sammy Gill <sgill26> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, qmmille, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://github.com/web-platform-tests/wpt/pull/43652 https://bugs.webkit.org/show_bug.cgi?id=266601 |
||
Sammy Gill
RenderFlexibleBox::layoutAndPlaceChildren will sometimes incorrectly dirty the preferred widths bit of flex items with a call to updateBlockChildDirtyBitsBeforeLayout. This is incorrect since this is down towards the end of layout and we never compute the preferred widths for flex items after this point. This dirtying should happen if the content of the flex item changes, since that is what the intrinsic sizes is based off of, or if there is some other related style change on the flexbox that could impact it (e.g. items with an aspect-ratio for the content based minimum size: https://drafts.csswg.org/css-flexbox-1/#content-based-minimum-size)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sammy Gill
rdar://117181858
Sammy Gill
Pull request: https://github.com/WebKit/WebKit/pull/19807
EWS
Committed 271995@main (efb0cb853cc0): <https://commits.webkit.org/271995@main>
Reviewed commits have been landed. Closing PR #19807 and removing active labels.
Sammy Gill
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/43652
Sammy Gill
*** Bug 266601 has been marked as a duplicate of this bug. ***
Sammy Gill
For future context: The effects of this bug was first reported on https://www.amazon.com/stores/Jellycat/page/92DE52A7-85AC-40F4-A3A5-08B62869740E?ref_=ast_bln