Summary: | Build failure cause by bindings not being regenerated after settings are removed | ||
---|---|---|---|
Product: | WebKit | Reporter: | Kdwk <kdwkleung> |
Component: | CMake | Assignee: | Patrick Griffis <pgriffis> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bugs-noreply, don.olmstead, Hironori.Fujii, mcatanzaro, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | PC | ||
OS: | Linux |
Description
Kdwk
2023-11-03 07:00:09 PDT
Looks like JSLocalDOMWindow.cpp was not regenerated after https://github.com/WebKit/WebKit/pull/19916/ *** Bug 264196 has been marked as a duplicate of this bug. *** I think something is wrong with the dependencies generated by GENERATE_BINDINGS in WebCoreMacros.cmake. It might suffice to add a global dependency on ${WTF_DIR}/Scripts/Preferences/UnifiedWebPreferences.yaml, which would cause all bindings to be regenerated when any setting changes. I'm not sure if we can be more precise than this or not. Probably not. CC Don and Fujii for opinions. Here is a generated supplemental_dependency.tmp. I removed path prefixes. > page/LocalDOMWindow.idl Modules/cookie-store/LocalDOMWindow+CookieStore.idl Modules/speech/LocalDOMWindow+SpeechSynthesis.idl Modules/webdatabase/LocalDOMWindow+WebDatabase.idl animation/AnimationFrameProvider.idl dom/GlobalEventHandlers.idl page/DOMWindow.idl page/LocalDOMWindow+CSSOM.idl page/LocalDOMWindow+CSSOMView.idl page/LocalDOMWindow+Compat.idl page/LocalDOMWindow+DeviceMotion.idl page/LocalDOMWindow+DeviceOrientation.idl page/LocalDOMWindow+RequestIdleCallback.idl page/LocalDOMWindow+Selection.idl page/LocalDOMWindow+VisualViewport.idl page/WindowEventHandlers.idl page/WindowLocalStorage.idl page/WindowOrWorkerGlobalScope.idl page/WindowSessionStorage.idl WebKitBuild/Debug/WebCore/DerivedSources/LocalDOMWindowConstructors.idl (...) > page/WindowOrWorkerGlobalScope.idl Modules/cache/WindowOrWorkerGlobalScope+Caches.idl Modules/fetch/WindowOrWorkerGlobalScope+Fetch.idl Modules/indexeddb/WindowOrWorkerGlobalScope+IndexedDatabase.idl page/WindowOrWorkerGlobalScope+Crypto.idl page/WindowOrWorkerGlobalScope+Performance.idl LocalDOMWindow.idl line contains WindowOrWorkerGlobalScope.idl, but WindowOrWorkerGlobalScope+Fetch.idl. It seems that it doesn't understand nesting mixin. Pull request: https://github.com/WebKit/WebKit/pull/26046 Committed 276276@main (d679abb2e0d1): <https://commits.webkit.org/276276@main> Reviewed commits have been landed. Closing PR #26046 and removing active labels. |