Bug 264071
Summary: | Sync 'svg.css' UA stylesheet with SVG2 Web Specification | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | heycam, ntim, rbuis, sabouhallawa, webkit-bug-importer, zimmermann |
Priority: | P2 | Keywords: | InRadar |
Version: | Safari Technology Preview | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Ahmad Saleem
Hi Team,
While going through random google searches, I came across that we don't have few of SVG UA Stylesheet rules, I think syncing them up would be good idea:
Web-Spec Link: https://svgwg.org/svg2-draft/styling.html#UAStyleSheet
We don't have:
*[xml|space=preserve] {
text-space-collapse: preserve-spaces;
}
defs,
clipPath, mask, marker,
desc, title, metadata,
pattern, linearGradient, radialGradient,
script, style,
symbol {
display: none !important;
}
:host(use) > symbol {
display: inline !important;
}
and also
:link, :visited {
cursor: pointer;
}
____
From above.
> text-space-collapse is renamed to 'white-space-collapse', so need to update and also :link and :visited, would need 'WebKit' specific bits.
Just raising, so we can fix them up and also would like to get inputs from others.
Thanks!
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
We don't have to adopt all since they might not be right but we should evaluate, which don't lead to any regression.
On Experimental basis, I copy pasted and tried and it leads to 1200+ test differences (from SVG and WPT 'SVG' directory).
Nikolas Zimmermann
(In reply to Ahmad Saleem from comment #1)
> We don't have to adopt all since they might not be right but we should
> evaluate, which don't lead to any regression.
>
> On Experimental basis, I copy pasted and tried and it leads to 1200+ test
> differences (from SVG and WPT 'SVG' directory).
Still makes sense, to adopt that.
Nikolas Zimmermann
(In reply to Ahmad Saleem from comment #1)
> We don't have to adopt all since they might not be right but we should
> evaluate, which don't lead to any regression.
>
> On Experimental basis, I copy pasted and tried and it leads to 1200+ test
> differences (from SVG and WPT 'SVG' directory).
Still makes sense, to adopt that.
Radar WebKit Bug Importer
<rdar://problem/118149143>
Ahmad Saleem
Nikolas - I will create separate bugs (using this as blocker) to do them one by one to ensure that I don't regress anything. :-)
Tim Nguyen (:ntim)
WebKit doesn't implement `white-space-collapse: preserve-spaces;` currently.
Ahmad Saleem
NOTE - text-xml-space-001.svg will be progressed after:
*[xml|space=preserve] {
text-space-collapse: preserve-spaces;
}
Currently, Blink and WebKit (post my change yesterday), make it work like 'nowrap'.