Bug 263953 – [Win] Regressions after ICU 74 update

• Component: Text
• Status: RESOLVED FIXED

[Fujii Hironori]

Some regressions are found after updating to ICU 74.1 from 73.2.

Release v2023.10.31 · WebKitForWindows/WebKitRequirements
https://github.com/WebKitForWindows/WebKitRequirements/releases/tag/v2023.10.31

Buildbot: builder WinCairo-64-bit-Debug-Tests build 21230
https://build.webkit.org/#/builders/727/builds/21230

  fast/css/line-height-determined-by-primary-font.html [ Crash ]
  fast/dom/HTMLScriptElement/script-decoding-error-after-setting-src.html [ Crash ]
  http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html [ Crash ]
  fast/url/idna2008.html [ Failure ]
  fast/url/url-hostname-encoding.html [ Failure ]

[Fujii Hironori]

https://build.webkit.org/results/WinCairo-64-bit-Debug-Tests/269979@main%20(21230)/fast/dom/HTMLScriptElement/script-decoding-error-after-setting-src-stderr.txt

ASSERTION FAILED: (*array)[6555] == 0xe5e5
C:\BW\WinCairo-64-bit-Debug-Build\build\Source\WebCore\PAL\pal\text\EncodingTables.cpp(8630) : operator()
1   00007FF9078C1C19 WTFCrash
2   00007FF8DD3B730D WTFCrashWithInfo
3   00007FF8E1E0D9F2 PAL::gb18030::<lambda_4>::operator()
4   00007FF8E1E0D703 std::invoke<`lambda at C:\BW\WinCairo-64-bit-Debug-Build\build\Source\WebCore\PAL\pal\text\EncodingTables.cpp:8611:26'>
5   00007FF8E1E0C249 std::call_once<`lambda at C:\BW\WinCairo-64-bit-Debug-Build\build\Source\WebCore\PAL\pal\text\EncodingTables.cpp:8611:26'>
6   00007FF8E1E0C1B4 PAL::gb18030
7   00007FF8E1E1B52D PAL::TextCodecCJK::gb18030Decode::<lambda_11>::operator()
8   00007FF8E1E1AFB9 WTF::Detail::CallableWrapper<`lambda at C:\BW\WinCairo-64-bit-Debug-Build\build\Source\WebCore\PAL\pal\text\TextCodecCJK.cpp:951:17',PAL::TextCodecCJK::SawError,unsigned char,WTF::StringBuilder &>::call
9   00007FF8E1E1CCD7 WTF::Function<PAL::TextCodecCJK::SawError (unsigned char, WTF::StringBuilder &)>::operator()
10  00007FF8E1E11FD0 PAL::TextCodecCJK::decodeCommon
11  00007FF8E1E134CE PAL::TextCodecCJK::gb18030Decode
12  00007FF8E1E136B3 PAL::TextCodecCJK::gbkDecode
13  00007FF8E1E13CE2 PAL::TextCodecCJK::decode
14  00007FF8E0B0479B WebCore::TextResourceDecoder::decode
15  00007FF8DFE6EA94 WebCore::TextResourceDecoder::decode
16  00007FF8DFE6CF63 WebCore::DecodedDataDocumentParser::appendBytes
17  00007FF8E0A16F7F WebCore::DocumentWriter::addData
18  00007FF8E0A106A3 WebCore::DocumentLoader::commitData
19  00007FF8FA9693FF WebKit::WebLocalFrameLoaderClient::committedLoad
20  00007FF8E0A15B6A WebCore::DocumentLoader::commitLoad
21  00007FF8E0A172DC WebCore::DocumentLoader::dataReceived
22  00007FF8E0A1702B WebCore::DocumentLoader::dataReceived
23  00007FF8E0B78A61 WebCore::CachedRawResource::notifyClientsDataWasReceived
24  00007FF8E0B7884E WebCore::CachedRawResource::updateBuffer
25  00007FF8E0B02304 WebCore::SubresourceLoader::didReceiveBuffer
26  00007FF8E0AE8A75 WebCore::ResourceLoader::didReceiveData
27  00007FF8FA873F44 WebKit::WebResourceLoader::didReceiveData
28  00007FF8F96D9BED IPC::callMemberFunction<WebKit::WebResourceLoader,WebKit::WebResourceLoader,void (IPC::SharedBufferReference &&, unsigned long long),std::tuple<IPC::SharedBufferReference,unsigned long long> >::<lambda_1>::operator()<IPC::SharedBufferReference,unsigned long long>
29  00007FF8F96D9BA7 std::invoke<`lambda at C:\BW\WinCairo-64-bit-Debug-Build\build\Source\WebKit\Platform\IPC\HandleMessage.h:135:9',IPC::SharedBufferReference,unsigned long long>
30  00007FF8F96D9B6E std::_Apply_impl<`lambda at C:\BW\WinCairo-64-bit-Debug-Build\build\Source\WebKit\Platform\IPC\HandleMessage.h:135:9',std::tuple<IPC::SharedBufferReference,unsigned long long>,0,1>
31  00007FF8F96D9B22 std::apply<`lambda at C:\BW\WinCairo-64-bit-Debug-Build\build\Source\WebKit\Platform\IPC\HandleMessage.h:135:9',std::tuple<IPC::SharedBufferReference,unsigned long long> >

[Fujii Hironori]

https://build.webkit.org/results/WinCairo-64-bit-Debug-Tests/269979@main%20(21230)/fast/url/idna2008-diff.txt

--- C:\BW\WinCairo-64-bit-Debug-Tests\build\layout-test-results\fast/url/idna2008-expected.txt
+++ C:\BW\WinCairo-64-bit-Debug-Tests\build\layout-test-results\fast/url/idna2008-actual.txt
@@ -17,8 +17,8 @@
 PASS canonicalize('http://look͏out.net/') is 'http://lookout.net/'
 PASS canonicalize('http://gOoGle.com/') is 'http://google.com/'
 FAIL canonicalize('http://ড়.com/') should be http://ড়.com/. Was http://xn--15b8c.com/.
-PASS canonicalize('http://ẞ.com/') is 'http://ss.com/'
-PASS canonicalize('http://ẞ.foo.com/') is 'http://ss.foo.com/'
+FAIL canonicalize('http://ẞ.com/') should be http://ss.com/. Was http://xn--zca.com/.
+FAIL canonicalize('http://ẞ.foo.com/') should be http://ss.foo.com/. Was http://xn--zca.foo.com/.
 FAIL canonicalize('http://-foo.bar.com/') should be http:///. Was http://-foo.bar.com/.
 FAIL canonicalize('http://foo-.bar.com/') should be http:///. Was http://foo-.bar.com/.
 FAIL canonicalize('http://ab--cd.com/') should be http:///. Was http://ab--cd.com/.

[Fujii Hironori]

ICU - International Components for Unicode - ICU 74
https://icu.unicode.org/download/74

[ICU-22420] Align GB18030 decoders with the WHATWG decoding specification - Unicode Consortium
https://unicode-org.atlassian.net/browse/ICU-22420

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/19769

[EWS]

Committed 270019@main (5a759283ec61): <https://commits.webkit.org/270019@main>

Reviewed commits have been landed. Closing PR #19769 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/117754691>