Bug 26395

Summary:

REGRESSION (r40813-r40884): No caret after going back/forward to page with focused text field

Product:

WebKit

Reporter:

mitz

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Reinstate call to CachedPage::restore()	darin: review+

Description mitz 2009-06-14 20:01:41 PDT

Steps to reproduce:
1) Go to <about:blank>
2) In the same tab, go to <data:text/html,%3Cinput%3E>
3) Click in the text field
4) Choose History > Back
5) Choose History > Forward

Result:
The text field is focused, but there is no caret and typing does not enter text in the field.

Comment 1 mitz 2009-06-14 20:02:13 PDT

<rdar://problem/6971333>

Comment 2 mitz 2009-06-14 20:23:28 PDT

The code that’s supposed to restore the selection is in CachedPage::restore(). However, in TOT, CachedPage::restore() is unreachable (I verified this by removing its definition and building WebCore successfully).

Comment 3 mitz 2009-06-14 20:29:43 PDT

bisect-builds puts the regression between r40813 and r40884. Based on my previous comment, I think it was <http://trac.webkit.org/changeset/40870>.

Comment 4 mitz 2009-06-14 20:45:57 PDT

Created attachment 31277 [details]
Reinstate call to CachedPage::restore()

Comment 5 mitz 2009-06-14 21:38:14 PDT

Fixed in <http://trac.webkit.org/projects/webkit/changeset/44676>.