Bug 263892

Summary:

REGRESSION(267944@main): wpt /css/CSS2/positioning/abspos-block-level-001.html

Product:

WebKit

Reporter:

Sam Sneddon [:gsnedders] <gsnedders>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=260832
https://bugs.webkit.org/show_bug.cgi?id=209735

Attachments:

Description	Flags
test reduction	none
Patch	none
Patch	none
Patch	none
Patch	none
[fast-cq]Patch	none

Sam Sneddon [:gsnedders]

Reported 2023-10-30 09:30:15 PDT

See https://wpt.fyi/results/css/CSS2/positioning/abspos-block-level-001.html?run_id=5133309367025664&run_id=5150860515999744

Attachments
test reduction (100 bytes, text/html) 2023-10-30 13:42 PDT, alan	no flags	Details
Patch (10.04 KB, patch) 2023-10-31 13:16 PDT, alan	no flags	Details Formatted Diff Diff
Patch (12.04 KB, patch) 2023-10-31 14:22 PDT, alan	no flags	Details Formatted Diff Diff
Patch (12.31 KB, patch) 2023-10-31 16:26 PDT, alan	no flags	Details Formatted Diff Diff
Patch (12.39 KB, patch) 2023-10-31 20:51 PDT, alan	no flags	Details Formatted Diff Diff
[fast-cq]Patch (12.39 KB, patch) 2023-11-01 06:55 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-10-30 09:30:44 PDT

<rdar://problem/117690490>

alan

Comment 2 2023-10-30 13:42:24 PDT

Created attachment 468416 [details] test reduction it looks like trimmed trailing whitespace confuses out-of-flow static position logic.

alan

Comment 3 2023-10-30 20:49:27 PDT

2 issues: - out-of-flow boxes has to be passed in as objectReplacementCharacter (and not as truly opaque items) to icu (InlineItemsBuilder::buildBidiParagraph) - right to left inline direction (has nothing to do with bidi) needs "visually backwards" search when looking for "before" in-flow content to decide where (display: block) out-of-flow box should go (InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes) (have a local fix, will upload a patch tomorrow)

alan

Comment 4 2023-10-31 13:16:32 PDT

Created attachment 468432 [details] Patch

alan

Comment 5 2023-10-31 13:17:34 PDT

(In reply to zalan from comment #2) > Created attachment 468416 [details] > test reduction > > it looks like trimmed trailing whitespace confuses out-of-flow static > position logic. 270022@main has addressed it.

alan

Comment 6 2023-10-31 14:22:52 PDT

Created attachment 468434 [details] Patch

alan

Comment 7 2023-10-31 16:26:58 PDT

Created attachment 468436 [details] Patch

alan

Comment 8 2023-10-31 20:51:55 PDT

Created attachment 468438 [details] Patch

alan

Comment 9 2023-11-01 06:55:11 PDT

Created attachment 468442 [details] [fast-cq]Patch

EWS

Comment 10 2023-11-01 11:56:51 PDT

Committed 270069@main (f1664d74b5e3): <https://commits.webkit.org/270069@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468442 [details].

Note You need to log in before you can comment on or make changes to this bug.