Bug 26372

Summary: Share ImageSource.cpp for platforms using the WebCore image decoders
Product: WebKit Reporter: Holger Freyther <zecke>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
First attempt at creating a Shared ImageSource.cpp
none
Second go, based on ToT and unify Skia, WX, Cairo eric: review-

Holger Freyther
Reported 2009-06-13 09:14:27 PDT
When looking at ImageSourceWX.cpp and ImageSourceCairo.cpp 90% of the code is the same and the only difference is going from the buffer to the native image. The code should be shared.
Attachments
First attempt at creating a Shared ImageSource.cpp (22.79 KB, patch)
2009-06-13 09:17 PDT, Holger Freyther 		no flags
DetailsFormatted DiffDiff
Second go, based on ToT and unify Skia, WX, Cairo (22.00 KB, patch)
2009-06-13 19:09 PDT, Holger Freyther 		eric: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Holger Freyther
Comment 1 2009-06-13 09:17:28 PDT
Created attachment 31238 [details] First attempt at creating a Shared ImageSource.cpp Create ImageSource.cpp with code from WX and Cairo. Change the Gtk+ buildsystem to build that, attempt to change the WX buildsystem to use it too. No functional change should be introduced for cairo, for wx the fileName() method got implemented. Use the ENABLE(WEBCORE_IMAGE_DECODERS) to guard this new feature.
Holger Freyther
Comment 2 2009-06-13 19:09:56 PDT
Created attachment 31248 [details] Second go, based on ToT and unify Skia, WX, Cairo rebased to ToT and also include skia.
Eric Seidel (no email)
Comment 3 2009-06-14 02:16:57 PDT
Comment on attachment 31248 [details] Second go, based on ToT and unify Skia, WX, Cairo I don't see the ImageSource.cpp changes?
Eric Seidel (no email)
Comment 4 2009-06-14 02:17:32 PDT
Aside from the missing file, I'm all about minus lines! :)
Note You need to log in before you can comment on or make changes to this bug.