Bug 263699
Summary: | getComputedStyle does not return correct transform | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
Component: | Layout and Rendering | Assignee: | Joone Hur <joone> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bfulgham, graouts, mattwoodrow, simon.fraser, webkit-bug-importer, zalan |
Priority: | P2 | Keywords: | BrowserCompat, InRadar |
Version: | Safari Technology Preview | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://github.com/web-platform-tests/wpt/pull/42936 |
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another failing test case:
Test Case: https://jsfiddle.net/5oomd14v/
^ Chrome Canary 120 and Firefox Nightly 121 shows:
matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 1)
matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 1)
While Safari Technology Preview 181 shows:
matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 1)
none
____
Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=201174
WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/css/ComputedStyleExtractor.cpp#857
In `computedTransform` function and in below:
if (!style.hasTransform() || is<RenderInline>(renderer))
to
if (!style.hasTransform() || !renderer)
leads to passing above but failures in WPT test cases. I haven't explored further but just wanted to raise.
Thanks!
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/117523629>
Joone Hur
Pull request: https://github.com/WebKit/WebKit/pull/19685
EWS
Committed 269920@main (1f695bbf9449): <https://commits.webkit.org/269920@main>
Reviewed commits have been landed. Closing PR #19685 and removing active labels.
Joone Hur
Re-opening for pull request https://github.com/WebKit/WebKit/pull/19896
Joone Hur
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/42936
EWS
Committed 270557@main (f998524614f7): <https://commits.webkit.org/270557@main>
Reviewed commits have been landed. Closing PR #19896 and removing active labels.