Bug 263635 – window.history.replaceState('', '', '') has no effect in Safari on macOS

• Component: History
• Status: RESOLVED FIXED

window.history.replaceState('', '', '') behave differently on Safari on MacOS.

It is supposed to update the address bar to the default URL (before the hash parameter). But it has no effect on Safari on MacOS.

[Ahmad Saleem]

Can you share test case to reproduce the issue? Plus whether it is reproducible on latest Safari Technology Preview 181?

[Radar WebKit Bug Importer]

<rdar://problem/117782346>

Yes it is reproducible on Safari Technology Preview 181. I am working on test cases. Thanks!

[sideshowbarker]

Ideally what would be the most help is a WPT test that would be runnable under the WPT test harness.

You can find the existing such tests at https://github.com/web-platform-tests/wpt/tree/master/html/browsers/history/the-history-interface — for example, https://github.com/web-platform-tests/wpt/blob/master/html/browsers/history/the-history-interface/history_replacestate.html

And you can run those tests directly in any browser by going, for example, to http://wpt.live/html/browsers/history/the-history-interface/history_replacestate.html

So you might be able to just add a `window.history.replaceState('', '', '')` test (with an assert_equals or some other kind of assert_*) directly to a copy of the existing https://github.com/web-platform-tests/wpt/blob/master/html/browsers/history/the-history-interface/history_replacestate.html source

Created attachment 472419 [details]
index.html to illustrate the bug repro

I am attaching an index.html to illustrate a behavior related to how Safari on macOS handles URL changes when using the replaceState function. It is no repro on Chrome.
Repo Link of same index.html: https://github.com/HarnoorSinghKhurana/safari-test/tree/main

Live Test Link : https://exquisite-fudge-6ed920.netlify.app/

Expected Behavior:
1. Clicking "Go to Deep Link" should update the URL with the fragment (#/deeplink?test-id=6f5d61af).
2. Clicking "Back to Default Route" should clear the fragment and restore the URL to its base path.

In Safari on macOS, the clearDeepLink function donot clear the fragment from the URL, leaving it unchanged.

[Byungseon(Sun) Shin]

Add the attached TC on W3C: https://github.com/web-platform-tests/wpt/pull/47973

[Byungseon(Sun) Shin]

Tested on STP #202, confirmed that it has been fixed.

[Domenic Denicola]

This fix appears to contradict the spec, per https://html.spec.whatwg.org/#shared-history-push/replace-state-steps step 6.

[Byungseon(Sun) Shin]

@Domenic, the changes made on <https://bugs.webkit.org/show_bug.cgi?id=276375> patched by

[Byungseon(Sun) Shin]

@Domenic, the changes made on <https://bugs.webkit.org/show_bug.cgi?id=276375> patched by Patrick Griffis.

I think we have to go back the the patch and see what is the right path for the issue.

[Patrick Griffis]

I can look into this but is there no test case?

web-platform-tests/html/browsers/history/the-history-interface/history_replacestate.html PASSes.

> Expected Behavior:
> 1. Clicking "Go to Deep Link" should update the URL with the fragment (#/deeplink?test-id=6f5d61af).
> 2. Clicking "Back to Default Route" should clear the fragment and restore the URL to its base path.

This test works in WebKit main and Chrome, but not on Firefox 129.

[Patrick Griffis]

Pull request: https://github.com/WebKit/WebKit/pull/33402

[Patrick Griffis]

If I understand correctly, not updating the URL is correct per the spec. Firefox matched this, Chrome 127.0.6533.99 did not.

I've submitted a draft PR above.

Does this sound right Domenic?

[Patrick Griffis]

> is there no test case?

WebKit didn't have  html/browsers/history/the-history-interface/pushstate-replacestate-empty-string/ imported so that makes sense.

With my PR all tests pass.

[EWS]

Committed 283565@main (ba51e8eae852): <https://commits.webkit.org/283565@main>

Reviewed commits have been landed. Closing PR #33402 and removing active labels.