Bug 26343 – crash in www.bahn.de with WML turned on

• Component: WebCore Misc.
• Status: RESOLVED WONTFIX

[zaheer]

here's the crash trace

#0  0x4050efe4 in WebCore::RenderFieldset::findLegend () from /usr/local/lib/libwebkit-1.0.so.1
#1  0x4050f4f0 in WebCore::RenderFieldset::calcPrefWidths () from /usr/local/lib/libwebkit-1.0.so.1
#2  0x40500918 in WebCore::RenderBox::minPrefWidth () from /usr/local/lib/libwebkit-1.0.so.1
#3  0x40508ef8 in WebCore::RenderBox::calcWidth () from /usr/local/lib/libwebkit-1.0.so.1
#4  0x404fa990 in WebCore::RenderBlock::layoutBlock () from /usr/local/lib/libwebkit-1.0.so.1
#5  0x404eb6d0 in WebCore::RenderBlock::layout () from /usr/local/lib/libwebkit-1.0.so.1
#6  0x404f9b14 in WebCore::RenderBlock::layoutBlockChildren () from /usr/local/lib/libwebkit-1.0.so.1
#7  0x404fabd4 in WebCore::RenderBlock::layoutBlock () from /usr/local/lib/libwebkit-1.0.so.1
#8  0x404eb6d0 in WebCore::RenderBlock::layout () from /usr/local/lib/libwebkit-1.0.so.1
#9  0x404f9b14 in WebCore::RenderBlock::layoutBlockChildren () from /usr/local/lib/libwebkit-1.0.so.1
#10 0x404fabd4 in WebCore::RenderBlock::layoutBlock () from /usr/local/lib/libwebkit-1.0.so.1
#11 0x404eb6d0 in WebCore::RenderBlock::layout () from /usr/local/lib/libwebkit-1.0.so.1
#12 0x404f9b14 in WebCore::RenderBlock::layoutBlockChildren () from /usr/local/lib/libwebkit-1.0.so.1
#13 0x404fabd4 in WebCore::RenderBlock::layoutBlock () from /usr/local/lib/libwebkit-1.0.so.1
#14 0x404eb6d0 in WebCore::RenderBlock::layout () from /usr/local/lib/libwebkit-1.0.so.1
#15 0x404f9b14 in WebCore::RenderBlock::layoutBlockChildren () from /usr/local/lib/libwebkit-1.0.so.1
#16 0x404fabd4 in WebCore::RenderBlock::layoutBlock () from /usr/local/lib/libwebkit-1.0.so.1
#17 0x404eb6d0 in WebCore::RenderBlock::layout () from /usr/local/lib/libwebkit-1.0.so.1

The problem is a missing bracket in RenderField::findLegend with WML turned on 
patch follows.

[zaheer]

Created attachment 31194 [details]
patch fixes bahn.de crash with WML enabled

[Eric Seidel (no email)]

Comment on attachment 31194 [details]
patch fixes bahn.de crash with WML enabled

Needs a ChangeLog and a test case.  The test case should trigger the crash and otherwise print SUCCESS or PASS.

Otherwise this looks great!

[Nikolas Zimmermann]

(In reply to comment #1)
> Created an attachment (id=31194) [review]
> patch fixes bahn.de crash with WML enabled
> 
Oh, great that you found it! I found this problem some weeks ago, but indeed forgot to commit the fix!
Thanks for noticing!

As Eric said, we still need a simple layout test. Can you write one?

[Laszlo Gombos]

WML support is removed - http://trac.webkit.org/changeset/85256.