Bug 263362
| Summary: | Fix break with LAYER_BASED_SVG_ENGINE disabled after 269492@main | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yousuke Kimoto <Yousuke.Kimoto> |
| Component: | SVG | Assignee: | Yousuke Kimoto <Yousuke.Kimoto> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Yousuke Kimoto
When LAYER_BASED_SVG_ENGINE is disabled, RenderSVGShape is used in SVGRenderSupport.cpp and the class is defined LAYER_BASED_SVG_ENGINE enabled.
Also an inline error occurs:
Source\WebCore\rendering\svg\legacy\LegacyRenderSVGShape.h(102,17): error : inline function 'WebCore::LegacyRenderSVGShape::hasNonScalingStroke' is not defined [-Werror,-Wundefined-inline]
To solve the build break, it needs to add some conditional codes and include LegacyRenderSVGShapeInlines.h in SVGRenderSupport.cpp.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yousuke Kimoto
Pull request: https://github.com/WebKit/WebKit/pull/19272
EWS
Committed 269511@main (b2f96217de84): <https://commits.webkit.org/269511@main>
Reviewed commits have been landed. Closing PR #19272 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/117195926>