Bug 263305
| Summary: | [meta] Implement close requests and close watchers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Domenic Denicola <d> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | eoconnor, karlcow, lwarlow, mike, ryan, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 274717, 274719, 274832, 287873, 266379, 266554, 266989 | ||
| Bug Blocks: | |||
Domenic Denicola
This includes both the new CloseWatcher API, and hooking it up to <dialog> and popover="" so that they have the same behavior. (Including in edge cases like many of them being opened simultaneously.)
See:
* https://html.spec.whatwg.org/#close-requests-and-close-watchers
* https://github.com/WICG/close-watcher
* https://github.com/whatwg/html/pull/9462
* https://github.com/web-platform-tests/wpt/tree/master/close-watcher
* https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/closewatcher/
* https://source.chromium.org/chromium/chromium/src/+/main:content/browser/closewatcher/
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/117163294>
Luke Warlow
Pull request: https://github.com/WebKit/WebKit/pull/21939
Domenic Denicola
Small spec change coming here to improve web compat: https://github.com/whatwg/html/pull/10291
Karl Dubost
Safari is failing that Firefox and Chrome are passing.
https://wpt.fyi/results/close-watcher/user-activation/y-dialog-disconnected.html
Domenic Denicola
I mean, Safari is failing all the close watcher tests, right? Not just that one. https://wpt.fyi/results/close-watcher?label=experimental&label=master&aligned
EWS
Committed 289529@main (74e0b308c997): <https://commits.webkit.org/289529@main>
Reviewed commits have been landed. Closing PR #21939 and removing active labels.
Luke Warlow
Reopening so this can be used to track the full implementation that PR should have used a sub issue rather than the meta one.