Bug 263119
| Summary: | [AutoInstall] prefer wheels whenever possible | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfan2, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=263392 | ||
Sam Sneddon [:gsnedders]
There's very little reason _not_ to prefer wheels in general; we might not always be able to use them (e.g., we may be on a platform where wheels are rarely provided, or even where packaging doesn't currently have any concept of the platform such as iOS), but we should use them when possible.
AIUI, we rely on some things (in tests?) which aren't in the Buildbot wheel (c.f. https://github.com/buildbot/buildbot/commit/2d351c2270a22302149eecd11265ea2ce3ec6617, https://github.com/buildbot/buildbot/commit/d34e1ccd3e62748b6d0c83965486774cdfb1dacc, https://github.com/buildbot/buildbot/commit/7d5c1b1ccb7ff2fc01b44b064851cea8fc7af74c), but maybe the 2021 change (shipped in 3.5.0) gives us enough of what we care about in the wheel? It sounds like prior to that they didn't really consider the testing API to be public, which meant there was little-to-no way to test Buildbot configurations.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/116915892>
Sam Sneddon [:gsnedders]
(I have a change locally for this, but need to step out for a bit; will upload PR once I'm back.)
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/19045
EWS
Committed 269817@main (dba0adf16439): <https://commits.webkit.org/269817@main>
Reviewed commits have been landed. Closing PR #19045 and removing active labels.
Jonathan Bedard
Re-opening for pull request https://github.com/WebKit/WebKit/pull/19835
EWS
Committed 270059@main (219eb0bb7b43): <https://commits.webkit.org/270059@main>
Reviewed commits have been landed. Closing PR #19835 and removing active labels.