Bug 262870
| Summary: | Dead code in MediaPlayerPrivateWebM | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=264847 | ||
Jean-Yves Avenard [:jya]
Code to abort the current demuxing operation can be found in the MediaPlayerPrivateWebM , the code was copied from the SourceBufferPrivateAVFObjC but is not used [1]
`abort()` is only called in the destructor and so is redundant with simply testing that the weak pointer isn't null.
[1] https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm#1140-1144
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/116652806>
Jean-Yves Avenard [:jya]
Was fixed by bug 264847