Bug 26272
| Summary: | stop bundling the web inspector files for nightly builds | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick Mueller <pmuellr> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | bburg, graouts, joepeck, timothy, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Patrick Mueller
I noticed with the Safari 4.0 drop, that the inspector files are not bundled the way that they are in the nightly builds. ie, there are many small files instead of a singular inspector.js file. That was true for the Safari 4.0 beta as well; namely, that the inspector files were unbundled instead of bundled.
Not sure what the real advantage to having the files bundled is, for the nightly. It's actually a pain in the rear when debugging the debugger. I've resorted to a script which replaces the files in the inspector directory with the relevant unbundled files from a source drop.
I'll fix the build script to stop bundling (found it at one point), but I thought I'd double check and see if there was some good reason to have the big bundled inspector.js in the nightly builds.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mark Rowe (bdash)
It's probably more interesting to look in to why they're not being bundled in that fashion in production builds.
Patrick Mueller
It may be more interesting question for Apple developers, sure. Open up a radar report or whatever. ;-)
But for WebKit, and nightlies in particular, I'd like to argue to stop bundling. The downside must be quite small, in shipping unbundled, since that's what Safari is currently doing. The upside to shipping unbundled is that it makes developer's lives much easier.
Joseph Pecoraro
Just as a general observer:
How does unbundled affect load time performance of the inspector? I don't know how differently the Inspector is treated other then a regular webpage, or if the file:// URL is treated differently. Is it possible that WebKit can parallize the unbundled files, or is it like a webpage where many requests slow down initial load times? These are just questions, it seems to load just as fast in Safari 4 as the WebKit nightly. Inspecting the inspector in both Safari and WebKit show rather different load times of the different resources so I figured it would be worth pointing out.
Timothy Hatcher
The files were bundles initially to help load time of the Inspector. It was noticable. But it could help debug the nightlies too…
Patrick Mueller
Also see Comment 17 in Bug 26316 for additional issues the bundling is causing.
Timothy Hatcher
It is curious why they are not bundled in Productiosn builds. I inteneded to bundle them for Release and Production.
Radar WebKit Bug Importer
<rdar://problem/15801457>
Timothy Hatcher
I don't think this is worth doing. We combine resources for performance, and some developers live on the nightly need the Inspector to be fast. Debugging the Inspector via a nightly is not that common.