Summary: | Still update main resource meta-data if resource tracking is disabled | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, pfeldman, timothy | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Yury Semikhatsky
2009-06-08 05:27:04 PDT
Created attachment 31043 [details]
Update main resource meta-data when resource tracking is off
Created attachment 31044 [details]
Update main resource meta-data when resource tracking is off
Comment on attachment 31044 [details]
Update main resource meta-data when resource tracking is off
Using PassRefPtr here isn't correct, since you are not transfering ownership. The InspectorController still owns the resources. A plain pointer return is best.
r+ if you change that.
Created attachment 31047 [details]
Update main resource meta-data when resource tracking is off
Previous patch with Timothy's comment addressed.
|