Bug 262498
| Summary: | Use StringView in CSSParserToken and simplify its code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | CSS | Assignee: | Chris Dumez <cdumez> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | commit-queue, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 263153 | ||
| Bug Blocks: | |||
Chris Dumez
Use StringView in CSSParserToken and simplify its code.
Previously, CSSParserToken wasn't using StringView internally for better bit packing, as the size of this object matters a lot.
Instead, do better bit packing in StringView so that CSSParserToken can use it without increasing its size (24 bits on my macBookPro M1).
To better bit-pack StringView, we rely on PackedPtr to fit the is8Bit flag in the same word as the character pointer.
This is performance neutral on Speedometer.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/18508
EWS
Committed 268760@main (855b9cf6ef5a): <https://commits.webkit.org/268760@main>
Reviewed commits have been landed. Closing PR #18508 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/116381450>
WebKit Commit Bot
Re-opened since this is blocked by bug 263153