Bug 262490

Summary:

REGRESSION: STP 178 renders blank GitHub diff on load, correct on reload

Product:

WebKit

Reporter:

Jon <jon>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

ahmad.saleem792

Priority:

Version:

Safari Technology Preview

Hardware:

Mac (Apple Silicon)

OS:

macOS 14

Attachments:

Description	Flags
Video showing rendering bug.	none

Jon

Reported 2023-10-02 10:47:04 PDT

Created attachment 468028 [details] Video showing rendering bug. Starting on STP 178 (I think, it's definitely there in Release 179 (Safari 17.0, WebKit 19617.1.8.1)), GitHub diffs in PRs are initially rendered but then rerender to have blank text content. There's not even any text in the selection highlight. A subsequent reload renders it correctly, and the correct rendering seems to be cached, as even a new tab with the same diff renders correctly. However, only that diff renders correctly, other GitHub diffs show the same issue. I've attached a video to demonstrate the bug. You can see it render correctly then lose the text and then rerender correctly when I refresh.

Attachments
Video showing rendering bug. (252.58 KB, video/mp4) 2023-10-02 10:47 PDT, Jon	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Ahmad Saleem

Comment 1 2023-10-02 14:45:34 PDT

It is fixed on WebKit ToT. Can't recall exact commit but it is fixed.

Ahmad Saleem

Comment 2 2023-10-02 14:47:04 PDT

Found it - https://github.com/WebKit/WebKit/commit/0b931b344706749ca75ff3c4d95969232a8304fd It was fixed by reverting bug 261016

Ahmad Saleem

Comment 3 2023-10-02 14:47:51 PDT

*** This bug has been marked as a duplicate of bug 261766 ***

Jon

Comment 4 2023-10-02 14:49:10 PDT

Confirmed, thanks. I'll try to test more with ToT in the future.

Note You need to log in before you can comment on or make changes to this bug.