Bug 26244

Summary:

[Qt] Build fix when NETSCAPE_PLUGIN_API support is turned off

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

zecke

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Proposed patch	ariya.hidayat: review+

Laszlo Gombos

Reported 2009-06-07 12:41:32 PDT

After ChangeSets r44119, r44120 QtWebKit no longer builds when NETSCAPE_PLUGIN_API support is turned off. Here are the linker errors: obj/release/PluginPackageNone.o: In function `WebCore::PluginPackage::hash() const': PluginPackageNone.cpp:(.text._ZNK7WebCore13PluginPackage4hashEv+0x0): multiple definition of `WebCore::PluginPackage::hash() const' obj/release/PluginPackage.o:PluginPackage.cpp:(.text._ZNK7WebCore13PluginPackage4hashEv+0x0): first defined here obj/release/PluginPackageNone.o: In function `WebCore::PluginPackage::equal(WebCore::PluginPackage const&, WebCore::PluginPackage const&)': PluginPackageNone.cpp:(.text._ZN7WebCore13PluginPackage5equalERKS0_S2_+0x0): multiple definition of `WebCore::PluginPackage::equal(WebCore::PluginPackage const&, WebCore::PluginPackage const&)' obj/release/PluginPackage.o:PluginPackage.cpp:(.text._ZN7WebCore13PluginPackage5equalERKS0_S2_+0x0): first defined here obj/release/PluginPackageNone.o: In function `WebCore::PluginPackage::compareFileVersion(unsigned int const&) const': PluginPackageNone.cpp:(.text._ZNK7WebCore13PluginPackage18compareFileVersionERKj+0x0): multiple definition of `WebCore::PluginPackage::compareFileVersion(unsigned int const&) const' obj/release/PluginPackage.o:PluginPackage.cpp:(.text._ZNK7WebCore13PluginPackage18compareFileVersionERKj+0x0): first defined here

Attachments
Proposed patch (2.84 KB, patch) 2009-06-07 12:45 PDT, Laszlo Gombos	ariya.hidayat: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2009-06-07 12:45:54 PDT

Created attachment 31034 [details] Proposed patch

Ariya Hidayat

Comment 2 2009-06-08 05:06:24 PDT

Landed in r44495 http://trac.webkit.org/changeset/44495

Note You need to log in before you can comment on or make changes to this bug.