Bug 262418

Summary: AX: Expose LabeledBy relationships unconditionally.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Andres Gonzalez 2023-09-29 17:13:53 PDT 
.
Comment 1 Radar WebKit Bug Importer 2023-09-29 17:14:09 PDT 
<rdar://problem/116263097>
Comment 2 Andres Gonzalez 2023-09-29 17:17:14 PDT 
Created attachment 467983 [details]
Patch
Comment 3 Andres Gonzalez 2023-10-02 08:29:36 PDT 
Created attachment 468027 [details]
Patch

Fix for glib expectations.
Comment 4 Andres Gonzalez 2023-10-02 12:04:38 PDT 
Created attachment 468029 [details]
Patch

Fix for glib expectations, second attempt.
Comment 5 Andres Gonzalez 2023-10-02 14:34:05 PDT 
Created attachment 468032 [details]
Patch

Fixes failing imported/w3c AccName test.
Comment 6 Tyler Wilcock 2023-10-02 18:36:38 PDT 
Comment on attachment 468032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468032&action=review

> COMMIT_MESSAGE:7
> +In COCOA platforms, we had the constraint of only exposing the LabeledBy relationship via the TitleUIElement property under certain conditions. This restriction is no longer needed in most situations and this patch removes it. The exception is when the Element has an aria-label attribute, in whic case we still return null TitleUIElement to force clients to use the aria-label .

Extra space before the period here.

to force clients to use the aria-label .

Also typo on whic

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:253
> +    // We impose the restriction that if there is more than one label element for the given Node, then should return none.

Missing a word here I think.

then should return none vs. then we should return none.
Comment 7 Andres Gonzalez 2023-10-03 06:30:22 PDT 
Created attachment 468043 [details]
Patch
Comment 8 Andres Gonzalez 2023-10-03 06:32:47 PDT 
(In reply to Tyler Wilcock from comment #6)
> Comment on attachment 468032 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=468032&action=review
> 
> > COMMIT_MESSAGE:7
> > +In COCOA platforms, we had the constraint of only exposing the LabeledBy relationship via the TitleUIElement property under certain conditions. This restriction is no longer needed in most situations and this patch removes it. The exception is when the Element has an aria-label attribute, in whic case we still return null TitleUIElement to force clients to use the aria-label .
> 
> Extra space before the period here.
> 
> to force clients to use the aria-label .
> 
> Also typo on whic
> 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:253
> > +    // We impose the restriction that if there is more than one label element for the given Node, then should return none.
> 
> Missing a word here I think.
> 
> then should return none vs. then we should return none.

Thanks, typos fixed.
Comment 9 EWS 2023-10-03 07:59:53 PDT 
Committed 268777@main (5280addb0ce9): <https://commits.webkit.org/268777@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468043 [details].