Bug 262410

Summary: [IFC][Cleanup] InlineFormattingContext should construct/own InlineLayoutState
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
[fast-cq]Patch none

alan
Reported 2023-09-29 15:52:55 PDT
ssia
Attachments
Patch (43.52 KB, patch)
2023-09-29 16:10 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (43.67 KB, patch)
2023-09-29 18:19 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (43.70 KB, patch)
2023-09-29 18:56 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (46.57 KB, patch)
2023-10-01 08:15 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-09-29 16:10:15 PDT
Created attachment 467981 [details] Patch
alan
Comment 2 2023-09-29 18:19:54 PDT
Created attachment 467986 [details] Patch
alan
Comment 3 2023-09-29 18:56:05 PDT
Created attachment 467987 [details] Patch
Antti Koivisto
Comment 4 2023-10-01 03:57:54 PDT
Comment on attachment 467987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467987&action=review nice! > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:771 > + if (auto adjustedRect = InlineFormattingQuirks::adjustedRectForLineGridLineAlign(constraints.logicalRect, formattingContext().root().style(), inlineLayoutState())) > constraints.logicalRect = *adjustedRect; adjustedRectForLineGridLineAlign can now be turned non-static and called via formattingContext().formattingQuirks(). Then it will only need the constraints.logicalRect parameter.
alan
Comment 5 2023-10-01 06:50:22 PDT
(In reply to Antti Koivisto from comment #4) > Comment on attachment 467987 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467987&action=review > > nice! > > > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:771 > > + if (auto adjustedRect = InlineFormattingQuirks::adjustedRectForLineGridLineAlign(constraints.logicalRect, formattingContext().root().style(), inlineLayoutState())) > > constraints.logicalRect = *adjustedRect; > > adjustedRectForLineGridLineAlign can now be turned non-static and called via > formattingContext().formattingQuirks(). Then it will only need the > constraints.logicalRect parameter. good point!
alan
Comment 6 2023-10-01 08:15:46 PDT
Created attachment 468003 [details] [fast-cq]Patch
EWS
Comment 7 2023-10-01 09:55:50 PDT
Committed 268703@main (8ac5e0757320): <https://commits.webkit.org/268703@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468003 [details].
Radar WebKit Bug Importer
Comment 8 2023-10-01 09:56:13 PDT
<rdar://problem/116314369>
Note You need to log in before you can comment on or make changes to this bug.