Bug 26237

Summary:

Web Inspector: Web Workers have no access to console for debugging

Product:

WebKit

Reporter:

Zachary Johnson <zachary.johnson>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bburg, buildbot, commit-queue, dbates, graouts, joepeck, mattbaker, nvasilyev, paulirish, rniwa, timothy, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

525.x (Safari 3.2)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
[PATCH] Proposed Fix	timothy: review+, buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
[PATCH] For Landing	none

Description Zachary Johnson 2009-06-06 18:25:59 PDT

The new JavaScript Workers cannot access the console, which kind of brings debugging back to the dark ages.

Comment 1 Paul Irish 2011-12-03 13:31:59 PST

downstream issue: http://code.google.com/p/chromium/issues/detail?id=63383

Comment 2 Joseph Pecoraro 2016-02-13 01:28:57 PST

Lets at least get basic support for console.log. There is much to do, but getting just basic `console.log(message)` to work was not hard.

Comment 3 Radar WebKit Bug Importer 2016-02-13 01:29:14 PST

<rdar://problem/24643273>

Comment 4 Joseph Pecoraro 2016-02-13 01:31:11 PST

Created attachment 271279 [details]
[PATCH] Proposed Fix

Comment 5 Build Bot 2016-02-13 02:18:25 PST

Comment on attachment 271279 [details]
[PATCH] Proposed Fix

Attachment 271279 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/824883

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html

Comment 6 Build Bot 2016-02-13 02:18:28 PST

Created attachment 271280 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 7 Build Bot 2016-02-13 02:21:29 PST

Comment on attachment 271279 [details]
[PATCH] Proposed Fix

Attachment 271279 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/824887

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html

Comment 8 Build Bot 2016-02-13 02:21:31 PST

Created attachment 271281 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

Comment 9 Alexey Proskuryakov 2016-02-13 14:18:21 PST

+CONSOLE MESSAGE: line 37: Tests are running without the ability to do manual garbage collection. They will still work, but coverage will be suboptimal.
+CONSOLE MESSAGE: line 37: Tests are running without the ability to do manual garbage collection. They will still work, but coverage will be suboptimal.
+CONSOLE MESSAGE: line 37: Tests are running without the ability to do manual garbage collection. They will still work, but coverage will be suboptimal.
+CONSOLE MESSAGE: line 37: Tests are running without the ability to do manual garbage collection. They will still work, but coverage will be suboptimal.

Comment 10 Joseph Pecoraro 2016-02-15 12:35:35 PST

Created attachment 271358 [details]
[PATCH] For Landing

Yep, that test was logging from a worker. Updated its results, and it passed 100 times.

Comment 11 WebKit Commit Bot 2016-02-15 13:23:23 PST

Comment on attachment 271358 [details]
[PATCH] For Landing

Clearing flags on attachment: 271358

Committed r196594: <http://trac.webkit.org/changeset/196594>