Bug 26232 – build options in the build-webkit script are outdated

• Component: Tools / Tests
• Status: RESOLVED INVALID

in 44479, we have
'Optional Features' part in ./configure --help
  --disable-option-checking  ignore unrecognized --enable/--with options
  --disable-FEATURE       do not include FEATURE (same as --enable-FEATURE=no)
  --enable-FEATURE[=ARG]  include FEATURE [ARG=yes]                           
  --disable-dependency-tracking  speeds up one-time build                     
  --enable-dependency-tracking   do not reject slow dependency extractors     
  --disable-largefile     omit support for large files                        
  --enable-static[=PKGS]  build static libraries [default=no]                 
  --enable-shared[=PKGS]  build shared libraries [default=yes]                
  --enable-fast-install[=PKGS]                                                
                          optimize for fast installation [default=yes]        
  --disable-libtool-lock  avoid locking (might break parallel builds)         
  --enable-debug          turn on debugging default=no                        
  --enable-optimizations  turn on optimize builds (GCC only) default=yes      
  --enable-dashboard-support                                                  
                          enable Dashboard support default=yes                
  --enable-3D-transforms  enable support for 3D transforms default=no         
  --enable-channel-messaging                                                  
                          enable HTML5 channel messaging support default=no   
  --enable-javascript-debugger                                                
                          enable JavaScript debugger/profiler support         
                          default=yes                                         
  --enable-offline-web-applications                                           
                          enable HTML5 offline web applications support       
                          default=yes                                         
  --enable-dom-storage    enable HTML5 client-side session and persistent     
                          storage support default=yes                         
  --enable-database       enable HTML5 client-side database storage support   
                          default=yes                                         
  --enable-icon-database  enable icon database default=yes                    
  --enable-video          enable HTML5 video support default=yes              
  --enable-xpath          enable support for XPath default=yes                
  --enable-xslt           enable support for XSLT default=yes                 
  --enable-geolocation    enable support for geolocation default=no           
  --enable-gnomekeyring   enable support for gnomekeyring default=no          
  --enable-svg            enable support for SVG default=yes                  
  --enable-wml            enable support for WML default=no                   
  --enable-web-workers    enable support for Web Workers default=yes          
  --enable-svg-animation  enable support for SVG animation (experimental)     
                          default=yes                                         
  --enable-filters        enable support for filters (experimental)           
                          default=no                                          
  --enable-svg-fonts      enable support for SVG fonts (experimental)         
                          default=yes                                         
  --enable-svg-foreign-object                                                 
                          enable support for SVG foreign objects              
                          (experimental) default=yes                          
  --enable-svg-as-image   enable SVG as Image support (experimental)          
                          default=yes                                         
  --enable-svg-use-element                                                    
                          enable SVG use element support (experimental)       
                          default=yes                                         
  --enable-coverage       enable code coverage support default=no             
  --enable-fast-malloc    enable optimized memory allocator default=yes,      
                          default=no for debug builds                         
  --enable-jit            Enable JIT compilation default=yes                  
  --enable-gtk-doc        use gtk-doc to build documentation [default=no]     


and WebKitTools/Scripts/build-webkit --help:
  --[no-]3d-rendering               Toggle 3D rendering support (default: 0)
  --[no-]channel-messaging          Toggle MessageChannel and MessagePort support (default: 0)
  --[no-]database                   Toggle Database Support (default: 1)
  --[no-]dom-storage                Toggle DOM Storage Support (default: 1)
  --[no-]filters                    Toggle Filters support (default: 0)
  --[no-]geolocation                Toggle Geolocation support (default: 0)
  --[no-]gnomekeyring               Toggle GNOME Keyring Support (GTK+ port only) (default: 0)
  --[no-]icon-database              Toggle Icon database support (default: 1)
  --[no-]javascript-debugger        Toggle JavaScript Debugger/Profiler support (default: 1)
  --[no-]offline-web-applications   Toggle Offline Web Application Support (default: 1)
  --[no-]svg                        Toggle SVG support (default: 1)
  --[no-]svg-animation              Toggle SVG animation support (default: 1, implies SVG Support)
  --[no-]svg-as-image               Toggle SVG as Image support (default: 1, implies SVG Support)
  --[no-]svg-dom-objc-bindings      Toggle SVG DOM Objective-C bindings support (default: 0, implies SVG Support)
  --[no-]svg-fonts                  Toggle SVG fonts support (default: 1, implies SVG Support)
  --[no-]svg-foreign-object         Toggle SVG foreign object support (default: 1, implies SVG Support)
  --[no-]svg-use                    Toggle SVG use element support (default: 1, implies SVG Support)
  --[no-]video                      Toggle Video support (default: 1)
  --[no-]wml                        Toggle WML support (default: 0)
  --[no-]workers                    Toggle Web Workers support (default: 1)
  --[no-]xpath                      Toggle XPath support (default: 1)
  --[no-]xslt                       Toggle XSLT support (default: 1)

but now there're fewer options in build-webkit than in configure, some may had been superceded

I wonder using which one of build-webkit and autogen.sh/make is preferred.

[ChangSeok Oh]

I have been updating feature options in build-webkit file, and I will submit patch soon.

[ChangSeok Oh]

Created attachment 78386 [details]
a patch to update features in build-webkit script

This patch updates features option that you can choose when you build webkit using by Tool/Scripts/update-webkit script.
The features option is based on r75364

[Mark Rowe (bdash)]

Comment on attachment 78386 [details]
a patch to update features in build-webkit script

View in context: https://bugs.webkit.org/attachment.cgi?id=78386&action=review

This change doesn’t explain why the options that are being removed from build-webkit are being removed.  It is also adding a number of options that don’t appear to map to any underlying feature defines (e.g., they have no effect). It adds some flags that are of dubious value (e.g., opcode-stats). It also adds a number of flags that are specific to the GTK build system and in my mind are not interesting to add to build-webkit (e.g., shared, static, optimizations, fast-install). If someone wants to customize things to that degree then they’re better off using ./configure directly.

> Tools/Scripts/build-webkit:115
>        define => "ENABLE_3D_CANVAS", default => (isAppleMacWebKit() && !isTiger() && !isLeopard()), value => \$threeDCanvasSupport },

Command-line options are lowercase by convention.

> Tools/Scripts/build-webkit:118
> +      define => "ENABLE_3D_TRANSFORMS", default => 0, value => \$threeDTransformsSupport },

This change seems bogus. ENABLE_3D_TRANSFORMS is not a feature define that appears in the source from what I can see.

> Tools/Scripts/build-webkit:148
> +      define => "ENABLE_FAST_MALLOC", default => 1, value => \$fastMallocSupport },

Again, ENABLE_FAST_MALLOC does not appear to correspond to a feature define.

[ChangSeok Oh]

Thanks for your review.

hmm..
I have thought build-webkit is needed to update some options.
Becuase I faced follwoing warning when I build webkit using by build-webkit on linux system.

> $ ./Tools/Scripts/build-webkit --gtk --debug --prefix=/usr --3d-canvas
> configure: WARNING: unrecognized options: --enable-3d-canvas, --disable-3d-rendering, --disable-accelerated-2d-canvas, --disable-client-based-geolocation, --disable-datagrid, --disable-device-orientation, --enable-inspector, --disable-meter-tag, --enable-netscape-plugin, --disable-notifications, --disable-orientation-events, --enable-progress-tag, --disable-system-malloc, --disable-svg-dom-objc-bindings, --disable-tiled-backing-store, --disable-touch-events, --disable-wcss

1. 3d canvas option is defined in configure.ac.
However, its name isn't --enable-3d-canvas but --enable-3D-canvas.
I understand convention. but lowercase "enable-3d-canvas" is not valid option for configuration.
Is it collect that modifying configure.ac? I'm not sure but I thought modifying build-webkit is more simple way.

2. The other options removed in a patch are not valid for configure.
I couldn't find options matched in configure.ac (for instance, enable-datagrid)
Are they used in other place? then, It's my mistake. :p

3. Some feature are added newly but there are no options to contol.
For example, there is no option to enable/disable JIT in build-webkit.

> If someone wants to customize things to that degree then they’re better off using ./configure directly.
Then, is there no plan to update build-webkit?

[Mark Rowe (bdash)]

build-webkit is used on all platforms, not just GTK.  Making it accept only options that GTK’s ./configure accept will cause problems for non-GTK platforms.

[Martin Robinson]

Autotools is gone now, so I think this patch is invalid. Reopen if you are still interested in fixing it.