Bug 26223

Summary:

--makeargs build flag is passed even if no argument is given

Product:

WebKit

Reporter:

Andre Pedralho <apedralho>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
A patch to fix the issue.	none
Patch updated to match svn/master.	vestbo: review+

Description Andre Pedralho 2009-06-05 13:00:43 PDT

It is more an improvement than a bug because it does not break build system.

Comment 1 Andre Pedralho 2009-06-05 13:03:27 PDT

Created attachment 31008 [details]
A patch to fix the issue.

It just verify if user passed --makeargs before adding it to the list of build options.

Comment 2 Holger Freyther 2009-06-13 07:58:49 PDT

Is there any perl warning or such?

Comment 3 Andre Pedralho 2009-06-15 09:44:27 PDT

(In reply to comment #2)
> Is there any perl warning or such?
> 

No, there is no warning. It'd be just to avoid to pass it forward empty.

Comment 4 Andre Pedralho 2009-06-15 10:48:37 PDT

Created attachment 31298 [details]
Patch updated to match svn/master.

Comment 5 Tor Arne Vestbø 2009-06-18 09:52:30 PDT

Got to run, I'll land this tomorrow

Comment 6 Tor Arne Vestbø 2009-06-19 03:00:16 PDT

Landed in r44851