Bug 262216
| Summary: | REGRESSION(268472@main): 5 tests under http/tests/contentextensions/ are consistently failing. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Schwartz <ben_schwartz> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | Hironori.Fujii, webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=261007 | ||
Ben Schwartz
The following tests are consistently failing on macOS wk2 (including gpuprocess):
http/tests/contentextensions/main-resource-redirect-blocked.py
http/tests/contentextensions/main-resource-redirect-error.html
http/tests/contentextensions/block-everything-unless-domain.html
http/tests/contentextensions/block-everything-unless-domain-iframe.html
http/tests/contentextensions/block-everything-unless-domain-redirect.py
HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Fcontentextensions%2Fblock-everything-unless-domain-iframe.html&test=http%2Ftests%2Fcontentextensions%2Fblock-everything-unless-domain-redirect.py&test=http%2Ftests%2Fcontentextensions%2Fblock-everything-unless-domain.html&test=http%2Ftests%2Fcontentextensions%2Fmain-resource-redirect-blocked.py&test=http%2Ftests%2Fcontentextensions%2Fmain-resource-redirect-error.html&platform=mac
TEXT DIFF:
Multiple, attached.
DIFF URLs:
https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-Tests/268510@main%20(11298)/http/tests/contentextensions/main-resource-redirect-blocked-pretty-diff.html
https://build.webkit.org/results/Apple-Ventura-Release-AppleSilicon-WK2-Tests/268511@main%20(5152)/http/tests/contentextensions/main-resource-redirect-error-pretty-diff.html
https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-Tests/268510@main%20(11298)/http/tests/contentextensions/block-everything-unless-domain-pretty-diff.html
https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-Tests/268510@main%20(11298)/http/tests/contentextensions/block-everything-unless-domain-iframe-pretty-diff.html
https://build.webkit.org/results/Apple-Ventura-Release-AppleSilicon-WK2-Tests/268511@main%20(5152)/http/tests/contentextensions/block-everything-unless-domain-redirect-pretty-diff.html
REPRODUCIBILITY:
I was able to reproduce this issue on macOS Ventura (13.5, 22G74/arm64) ToT using the following command:
run-webkit-tools --verbose --clobber-old-results --iterations 10 http/tests/contentextensions/main-resource-redirect-blocked.py http/tests/contentextensions/main-resource-redirect-error.html http/tests/contentextensions/block-everything-unless-domain.html http/tests/contentextensions/block-everything-unless-domain-iframe.html http/tests/contentextensions/block-everything-unless-domain-redirect.py
REGRESSION:
I was able to identify a potential regression point at 258473@main. This issue did not reproduce before then, and changes at that point appear to be directly related to the issue.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/116143665>
Fujii Hironori
https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-Tests/268510@main%20(11298)/http/tests/contentextensions/main-resource-redirect-blocked-diff.txt
--- /Volumes/Data/worker/Apple-Monterey-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/contentextensions/main-resource-redirect-blocked-expected.txt
+++ /Volumes/Data/worker/Apple-Monterey-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/contentextensions/main-resource-redirect-blocked-actual.txt
@@ -1,3 +1,4 @@
+Failed: The URL was blocked by a content blocker (errorDomain=WebKitErrorDomain, code=104) for URL http://127.0.0.1:8000/contentextensions/main-resource-redirect-blocked.py
CONSOLE MESSAGE: Content blocker prevented frame displaying http://127.0.0.1:8000/contentextensions/resources/main-resource-redirect-blocked-target.html from loading a resource from http://127.0.0.1:8000/contentextensions/resources/main-resource-redirect-blocked-target.html
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
Fujii Hironori
268472@main is the culprit.
Fujii Hironori
The commit has no bugzilla ticket. I added a comment to the PR. https://github.com/WebKit/WebKit/pull/18028#issuecomment-1738189782
Ben Schwartz
Aha! You're right, the commit is 268472@main. Thank you for the correction!
EWS
Test gardening commit 268549@main (2e62b4812535): <https://commits.webkit.org/268549@main>
Reviewed commits have been landed. Closing PR #18316 and removing active labels.
Fujii Hironori
268551@main reverted the change. Resolved.
*** This bug has been marked as a duplicate of bug 262227 ***