Bug 262169
| Summary: | [GTK] build breaks with -DUSE_OPENGL_OR_ES=OFF: epoxy/egl.h no such file or directory | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Thomas Devoogdt <thomas.devoogdt> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Thomas Devoogdt
This new bug report was proposed in https://bugs.webkit.org/show_bug.cgi?id=261637#c4.
webkitgtk-2.42.0/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:39:10: fatal error: epoxy/egl.h: No such file or directory
39 | #include <epoxy/egl.h>
| ^~~~~~~~~~~~~
If USE_OPENGL_OR_ES=OFF, then we can't assume that EGL will be present. So the include + all it's usages should be guarded with e.g. USE(EGL).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Thomas Devoogdt
Note that the same does apply to AcceleratedSurfaceDMABuf.
Thomas Devoogdt
It seems that commit https://commits.webkit.org/265188@main introduced the problems. The USE(GBM) checks were dropped but should have been replaced by USE(EGL).
Thomas Devoogdt
PR:
main: https://github.com/WebKit/WebKit/pull/18346
2.42: https://github.com/WebKit/WebKit/pull/18347
EWS
Committed 268598@main (c124153d271b): <https://commits.webkit.org/268598@main>
Reviewed commits have been landed. Closing PR #18346 and removing active labels.
EWS
Committed 266719.76@bugfix/USE_EGL-2.42 (b751733c75f7): <https://commits.webkit.org/266719.76@bugfix/USE_EGL-2.42>
Reviewed commits have been landed. Closing PR #18347 and removing active labels.