Bug 26203

Summary:

Move parsing of 'attr(X)' values to own method

Product:

WebKit

Reporter:

Roland Steiner <rolandsteiner>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
patch - add new method for parsing of 'attr(X)' values	eric: review+

Roland Steiner

Reported 2009-06-04 20:07:39 PDT

[separated out from bug #26198] CSSParser.cpp/.h - move parsing of 'attr(X)' to own method move parsing of 'attr(X)' to its own method, in order to make re-using it easier. (E.g., CSS3 'ruby-span' would also use 'attr(X)')

Attachments
patch - add new method for parsing of 'attr(X)' values (3.38 KB, patch) 2009-06-04 20:10 PDT, Roland Steiner	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Roland Steiner

Comment 1 2009-06-04 20:10:49 PDT

Created attachment 30984 [details] patch - add new method for parsing of 'attr(X)' values

Eric Seidel (no email)

Comment 2 2009-06-04 20:26:07 PDT

Comment on attachment 30984 [details] patch - add new method for parsing of 'attr(X)' values Great!

Eric Seidel (no email)

Comment 3 2009-06-04 20:30:13 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/css/CSSParser.cpp M WebCore/css/CSSParser.h Committed r44448

Note You need to log in before you can comment on or make changes to this bug.