Bug 26202

Summary: add macros for primitive values to simplify CSSStyleSelector::applyProperty
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch - add macros for primitive values eric: review+

Roland Steiner
Reported 2009-06-04 20:00:15 PDT
[separated out from bug #26198] Like the other HANDLE_... macros used I added 2 more that also include the handling of primitive values. Using that allows to reduce the line count quite a bit. NOTE: There are some CSS properties that do not query whether a value is actually a primitive value, but do an assignment unconditionally. AFAICT, this would result in the asignment of a default value if the passed-in value is not, in fact, primitive. As these cases should only occur with malformed input anyway, and as the UA is supposed to ignore erroneous values, I believe my changes are correct in these cases. There was no change in layout test results.
Attachments
patch - add macros for primitive values (15.56 KB, patch)
2009-06-04 20:04 PDT, Roland Steiner 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2009-06-04 20:04:43 PDT
Created attachment 30982 [details] patch - add macros for primitive values see main bug description
Eric Seidel (no email)
Comment 2 2009-06-04 20:26:28 PDT
Comment on attachment 30982 [details] patch - add macros for primitive values Excellent!
Eric Seidel (no email)
Comment 3 2009-06-04 20:31:11 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/css/CSSStyleSelector.cpp Committed r44449
Note You need to log in before you can comment on or make changes to this bug.